Skip to content

Reviewer queue: Approve Selected bulk action - #134

Merged
TrueMessenger merged 1 commit into
mainfrom
feat/reviewer-bulk-approve
Jul 8, 2026
Merged

TrueMessenger merged 1 commit into
mainfrom
feat/reviewer-bulk-approve

Conversation

@TrueMessenger

Copy link
Copy Markdown
Owner

Summary

  • Add an "Approve Selected" bulk action to the review queue, alongside the existing "Delete Selected"
  • Only pending submissions with a Compliant or Compliant-with-substitutions verdict are approved; everything else in the selection (non-compliant, errored, already decided, or a stale pk) is skipped and the message reports how many were skipped
  • Each approval reuses the existing review_submission service and queues the member decision notification, same as the single-submission decide flow

Test plan

  • manage.py test fitcheck (758 tests, all green)
  • manage.py check clean
  • manage.py makemigrations fitcheck --check --dry-run reports no changes

Reviewers could bulk-delete from the queue but had to approve pending
submissions one at a time. Add an "Approve Selected" action next to
"Delete Selected" that approves the selected rows still pending with a
Compliant or Compliant-with-substitutions verdict, and reports how many
were skipped (already decided, non-compliant, errored, or a stale pk)
so those can be handled individually.
@TrueMessenger
TrueMessenger merged commit b0ee8f4 into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant