Repository navigation
Make EFT paste a pure sandbox: reviewable submissions require inventory validation - #131
Merged
Merged
Conversation
…ry validation Pasted text can't be tied to what a pilot actually has fitted, so it should never be able to stand in for a real submission. The Test a Fit page now always runs the check-only sandbox for every user (previously doctrine managers and reviewers could persist a real, reviewable FitSubmission from a paste); the mode POST field is now vestigial and accepted from legacy forms without effect. Re-checking a submission now only works for ESI-sourced submissions, since re-checking re-validates against the pilot's live inventory. Legacy EFT-paste submissions from before this change stay visible as read-only history; re-check on one shows an explanatory message instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FitSubmission, never notifies reviewers, and never reaches the review queue. Previously doctrine managers and reviewers could POST withoutmode=check_onlyto persist a real submission from a paste.modePOST field is now vestigial - accepted (including from legacy/cached forms) but has no effect, since the sandbox path always runs.Why
Pasted text is unverifiable - a pilot could paste the doctrine's own EFT export verbatim without owning the ship. Reviewable submissions should only ever come from something that was actually validated against a pilot's real inventory (ESI / corptools), so the paste tool is repositioned as what it's always been safest as: a self-check sandbox.
How tested
manage.py test fitcheck- full suite green (717 tests).manage.py check- clean.manage.py makemigrations fitcheck --check --dry-run- no changes (no model/behavior requires a migration).