Repository navigation
UI polish: de-duplicated fit-detail categories, chip-based doctrine picker, My Ships tab - #130
Merged
Merged
Conversation
…ps tab Fit detail: doctrine category badges were repeated once per doctrine chip that carried them; the categories loop is removed from the chip row and replaced with a single combined row below it, computed from the union of the fit's own directly-assigned categories and every category of every doctrine the fit belongs to (de-duped by pk, sorted by name). Test a Fit: the doctrine grading picker is now a row of toggle chips (Bootstrap .btn-check driving the existing .fc-chip look via a sibling selector) instead of a plain checkbox list, matching the chip styling used elsewhere. The filled state and a check icon both signal selection so the state isn't color-only. Pilot Fittings: "My Ships" (the ship-inventory audit) is promoted from a hub button to its own top-level tab, and the hub's jump button is relabelled to match. The redundant "Connect ESI access" button is removed from the hub - the per-character prompt on the My Ships page itself is already the actionable surface for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.btn-checkdriving the existing.fc-chiplook) instead of a plain checkbox list. Selection is shown by both fill color and a check icon, not color alone.Test plan
manage.py test fitcheck- 716 tests passmanage.py check- cleanmanage.py makemigrations fitcheck --check --dry-run- no missing migrationsfit_categoriescontext is deduped and ordered by name