Skip to content

fix(telemetry): align resource identity across signals#450

Merged
yordis merged 1 commit into
masterfrom
yordis/fix-telemetry-resource-identity
Jul 20, 2026
Merged

fix(telemetry): align resource identity across signals#450
yordis merged 1 commit into
masterfrom
yordis/fix-telemetry-resource-identity

Conversation

@yordis

@yordis yordis commented Jul 20, 2026

Copy link
Copy Markdown
Member
  • Operators need logs, metrics, and traces to identify the same node consistently during incident correlation.
  • A single resource contract prevents signal-specific identity drift as instrumentation expands.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability resource metadata only; no changes to request handling, auth, or persistence.

Overview
Introduces TelemetryServiceIdentity as the single source for OpenTelemetry resource attributes (service.name, service.instance.id from the node component name, service.version).

Metrics and traces now use that identity via CreateResourceBuilder() instead of a local helper that only set name and version—so exported traces/metrics match logs on instance id for correlation. OTLP logs drop inline attribute dictionaries and use the same type.

ClusterVNode builds the identity from options.GetComponentName() and passes it into ClusterVNodeStartup; unit tests cover attribute/resource parity and rejection of blank component names.

Reviewed by Cursor Bugbot for commit 837d758. Bugbot is set up for automated code reviews on this repo. Configure here.

@yordis
yordis merged commit 4348ff9 into master Jul 20, 2026
22 checks passed
@yordis
yordis deleted the yordis/fix-telemetry-resource-identity branch July 20, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant