hotfix proposal: properly multiply c2 and c3 together.#310
Open
jasperfirecai2 wants to merge 1 commit intoTrimps:masterfrom
Open
hotfix proposal: properly multiply c2 and c3 together.#310jasperfirecai2 wants to merge 1 commit intoTrimps:masterfrom
jasperfirecai2 wants to merge 1 commit intoTrimps:masterfrom
Conversation
Author
|
note that if this is the intended method of stacking, the wording for cinf should probably be more clear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a discussion in the discord, it seems that cinf bonus is not being correctly multiplied together. It is especially apparent at lower numbers. and c3 doesn't apply any bonus at all a c2 = 0;
due to calculating the c2 and c3 bonuses different in the cinf math, the c2 bonus is off by a factor of +100.
This is a suggested fix, to make it clear how the math actually should work if c2 and c3 are meant to multiply. Assuming totalward = 0 means 'add nothing to multiplier' and not 'multiply by 0'.
Images to show the disparity at low and high numbers
(should be -100), +1500% = x16