Radio Emotes + Possessive Emotes by nanbyt · Pull Request #463 · Triad-Sector/Triad_Sector

nanbyt · 2026-08-04T02:49:17Z

About the PR

Cherypicked the ability to send emotes over radio, as well as emoting possessively without being spaced weird, from Delta-V
This also adds "?" as shorthand for "looks confused"

Why / Balance

Must miao on radio,,,

Media

Image from original.

Demonstration video from original.
https://github.com/user-attachments/assets/e070d97f-12c3-4042-8a36-f6bab7d00199

Requirements

I have read relevant guidelines/documentation to this PR found on our devwiki.
I have added media to this PR or it does not require an ingame showcase.
I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Emote over radio using @![radio prefix] ex, @!; or @!:d
Emote possessively using @' ("s" not needed, or else youll look a fool)

Breaking changes

I have touched the forbidden chat code..

Changelog

🆑

add: ability to emote over radio using @![radio channel]
add: ability to emote possessively using @'
add: "?" shorthand emote for "looks confused"

* Changed up how emoting works This was a long 10 hours just to get the chat to behave slightly different. At least we can now scream over radio! Will most definitely need some more work to get bugs out since this is the first implementation. * Not ok This was unmarked for some reason... I don't remember unmarking this. * DeltaV comments Added comments to explain changes. Moved localization files to the _DV folder. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Moved code Moved code to more suitable files and added some comments. * Rights for robots Now those with intrinsic radios can also emote! * Fixes up some small stuff Changes to fix some small issues with the code to align it more with modern standards. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix by-ref event Never worked with this event type before so gonna hope this works. * Update Content.Shared/Chat/SharedChatSystem.Emote.cs Signed-off-by: pathetic meowmeow <uhhadd@gmail.com> * Update Content.Shared/Chat/SharedChatSystem.cs Signed-off-by: pathetic meowmeow <uhhadd@gmail.com> * Update Content.Server/Chat/Systems/ChatSystem.cs Signed-off-by: pathetic meowmeow <uhhadd@gmail.com> * fix style nits * remove conflicting chatsan --------- Signed-off-by: pathetic meowmeow <uhhadd@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

mnva0

Sorry if a review took a while. I had a look through every file and found some little things. I would've done a more thorough review but I'll leave that to the other maintainers who know C# better than me

nanbyt · 2026-08-06T03:15:10Z

Kaay! Removed extra lines and nittypicked the line commets

Splendid! Thank you

rebaserHEAD

Needs some work and then a final review. Thanks for your efforts on this one! Chat is a real pain.

rebaserHEAD · 2026-08-09T20:04:05Z

    }

+    // DeltaV
+    private void OnIntrinsicAudibleEmote(EntityUid uid, IntrinsicRadioTransmitterComponent component, EntityAudiblyEmotedEvent args)


Needs ref too, or it reads a stale copy once the headset handler starts nulling the channel correctly.

Suggested change

private void OnIntrinsicAudibleEmote(EntityUid uid, IntrinsicRadioTransmitterComponent component, EntityAudiblyEmotedEvent args)

private void OnIntrinsicAudibleEmote(EntityUid uid, IntrinsicRadioTransmitterComponent component, ref EntityAudiblyEmotedEvent args)

rebaserHEAD · 2026-08-09T20:04:05Z

+        // Triad - Prevent speaking emotes
+        if (args.emType == EmoteType.Audible || args.emType == EmoteType.AudiblePossessive)
+            {_chat.TrySendInGameICMessage(uid, message, InGameICChatType.Emote, ChatTransmitRange.GhostRangeLimitNoAdminCheck,
+            nameOverride: name, checkRadioPrefix: false, languageOverride: args.Language);
+            return;}


Brace style, and this re-emits through the plain emote wrap so a possessive emote loses its 's when it comes out of a speaker. Fine to leave the fidelity bit, but the braces should go.

Suggested change

// Triad - Prevent speaking emotes

if (args.emType == EmoteType.Audible || args.emType == EmoteType.AudiblePossessive)

{_chat.TrySendInGameICMessage(uid, message, InGameICChatType.Emote, ChatTransmitRange.GhostRangeLimitNoAdminCheck,

nameOverride: name, checkRadioPrefix: false, languageOverride: args.Language);

return;}

// Triad - Prevent speaking emotes

if (args.emType == EmoteType.Audible || args.emType == EmoteType.AudiblePossessive)

{

_chat.TrySendInGameICMessage(uid, message, InGameICChatType.Emote, ChatTransmitRange.GhostRangeLimitNoAdminCheck,

nameOverride: name, checkRadioPrefix: false, languageOverride: args.Language);

return;

}

rebaserHEAD · 2026-08-09T20:04:05Z

+            // if (!TryComp<HandsComponent>(uid, out var hands) || hands.Count < 1 ||
+            //     TryComp<CuffableComponent>(uid, out var cuffable) && _cuffable.IsCuffed((uid, cuffable)))
+            // {
+            //     _popup.PopupEntity(Loc.GetString("headset-cant-reach"), uid, uid, PopupType.SmallCaution);
+            //     return false;
+            // }
+
+            return true;


Dead block. If the reach check isn't wanted here, drop it rather than carrying commented DeltaV code we never ran. The "comment it out" rule is for upstream code we're diverging from, not for incoming ports.

Suggested change

// if (!TryComp<HandsComponent>(uid, out var hands) || hands.Count < 1 ||

// TryComp<CuffableComponent>(uid, out var cuffable) && _cuffable.IsCuffed((uid, cuffable)))

// {

// _popup.PopupEntity(Loc.GetString("headset-cant-reach"), uid, uid, PopupType.SmallCaution);

// return false;

// }

return true;

return true;

rebaserHEAD · 2026-08-09T20:04:05Z

+    EntityUid RadioSource,
+    EmoteType? emType //Triad


Positional record members should be PascalCase, and this one is public API that other systems now read.

Suggested change

EntityUid RadioSource,

EmoteType? emType //Triad

EntityUid RadioSource,

EmoteType? EmType //Triad

Call sites to follow: args.emType in RadioDeviceSystem.OnReceiveRadio.

nanbyt · 2026-08-10T03:07:26Z

Gulp, hopefully I didnt break anything. >< Thanks for catching the oopsies

mnva0

GitHub is still saying I need to review this but I already did a very basic review (unless my review was requested again somewhere I couldn't see?). I am commenting this in an attempt to make GitHub realize the fact I have reviewed this

Co-authored-by: rebaserHEAD <38984539+rebaserHEAD@users.noreply.github.com>

mnva0

I'm not sure why my review was rerequested, but I had a quick look through again. Looks fine minor-nitpickwise to me from my extremely superficial review, but I'm unqualified to review C# PRs

rebaserHEAD · 2026-08-27T02:40:34Z

First, sorry for the slow roll on this. I appreciate your patience while I was working on a few other things.

Secondly, I will say after considering this for a bit, that it's a bit odd to be able to emote over the radio which implies it's audio based in game. I might have a bit of a discussion with the other maintainers to chew this over. I'm on the fence with it leaning towards "No" but I can be convinced otherwise.

Utmanarn and others added 3 commits August 2, 2026 22:57

EmoteType.Audible

d96b4a8

github-actions Bot added S: Untriaged size/M C# FTL Changes to localization files and removed S: Untriaged size/M labels Aug 4, 2026

mnva0 previously requested changes Aug 5, 2026

View reviewed changes

Comment thread Resources/Locale/en-US/_DV/headset/headset-component.ftl Outdated

Comment thread Content.Server/Radio/EntitySystems/RadioSystem.cs Outdated

Comment thread Content.Server/Radio/EntitySystems/RadioDeviceSystem.cs Outdated

Removed unsued, changed notes

5c0fb0c

github-actions Bot added the size/M label Aug 6, 2026

nanbyt requested a review from mnva0 August 6, 2026 03:14

github-actions Bot added the S: Needs Review label Aug 6, 2026

I should have caught this typo

8bfa2d5

rebaserHEAD requested changes Aug 9, 2026

View reviewed changes

Added Suggested Changes

b16b833

mnva0 reviewed Aug 10, 2026

View reviewed changes

nanbyt requested a review from rebaserHEAD August 11, 2026 03:41

Apply suggestion from @rebaserHEAD

6253a12

Co-authored-by: rebaserHEAD <38984539+rebaserHEAD@users.noreply.github.com>

nanbyt requested a review from mnva0 August 26, 2026 06:39

mnva0 approved these changes Aug 26, 2026

View reviewed changes

Navigation Menu

Radio Emotes + Possessive Emotes - #463

Radio Emotes + Possessive Emotes#463
nanbyt wants to merge 7 commits into
Triad-Sector:mainfrom
nanbyt:Radio-Emotes

nanbyt commented Aug 4, 2026

Uh oh!

mnva0 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nanbyt commented Aug 6, 2026

Uh oh!

rebaserHEAD left a comment

Uh oh!

Uh oh!

Uh oh!

rebaserHEAD Aug 9, 2026

Uh oh!

rebaserHEAD Aug 9, 2026

Uh oh!

rebaserHEAD Aug 9, 2026

Uh oh!

rebaserHEAD Aug 9, 2026

Uh oh!

nanbyt commented Aug 10, 2026 •

edited

Loading

Uh oh!

mnva0 left a comment

Uh oh!

mnva0 left a comment

Uh oh!

rebaserHEAD commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	private void OnIntrinsicAudibleEmote(EntityUid uid, IntrinsicRadioTransmitterComponent component, EntityAudiblyEmotedEvent args)
	private void OnIntrinsicAudibleEmote(EntityUid uid, IntrinsicRadioTransmitterComponent component, ref EntityAudiblyEmotedEvent args)

Conversation

nanbyt commented Aug 4, 2026

About the PR

Why / Balance

Media

Requirements

How to test

Breaking changes

Uh oh!

mnva0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nanbyt commented Aug 6, 2026

Uh oh!

rebaserHEAD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rebaserHEAD Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

rebaserHEAD Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

rebaserHEAD Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

rebaserHEAD Aug 9, 2026

Choose a reason for hiding this comment

Uh oh!

nanbyt commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mnva0 left a comment

Choose a reason for hiding this comment

Uh oh!

mnva0 left a comment

Choose a reason for hiding this comment

Uh oh!

rebaserHEAD commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nanbyt commented Aug 10, 2026 •

edited

Loading