Port Starlight Clothing and Add to Loadout (Branch Name Change)

[pandoraberry]

About the PR

Ports the Starlight clothing pack from Wayfarer and integrates it into Triad's loadout system.

This includes importing the clothing loadouts, organizing them into Triad's existing loadout groups, and cleaning up invalid or duplicate entries encountered during the port.

Why / Balance

Expands player customization by adding a large selection of cosmetic clothing options. This PR does not significantly affect gameplay balance.

Media

Requirements

• I have read relevant guidelines/documentation to this PR found on our devwiki.
• I have added media to this PR or it does not require an ingame showcase.
• I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

• Open the loadout menu as a Spacer, Pilot, or Mercenary.
• Verify the new clothing appears in the correct loadout groups.
• Spawn each new clothing item in-game and verify it equips correctly.
• Check directional and in-hand sprites on multiple species.

Breaking changes

None.

Changelog
🆑

• add: Added a large selection of new civilian clothing options from Starlight to character loadouts!

[github-actions]

RSI Diff Bot; head commit 296ae35 merging into ec7d1b0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Uniforms/Jumpsuit/rainbow.rsi

State	Old	New	Status
inhand-left			Modified
inhand-right			Modified

Resources/Textures/_Starlight/Clothing/Head/Hats/belpero.rsi

State	Old	New	Status
equipped-HELMET			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Head/Hats/red_regalia.rsi

State	Old	New	Status
equipped-HELMET-avali			Added
equipped-HELMET-resomi			Added
equipped-HELMET-vox			Added
equipped-HELMET			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Neck/Cloaks/ari.rsi

State	Old	New	Status
equipped-NECK			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Neck/Cloaks/belpero.rsi

State	Old	New	Status
equipped-NECK			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Neck/Cloaks/red_regalia.rsi

State	Old	New	Status
equipped-NECK-avali			Added
equipped-NECK-resomi			Added
equipped-NECK-vox			Added
equipped-NECK			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Neck/Cloaks/shuba.rsi

State	Old	New	Status
equipped-NECK-hydrakin			Added
equipped-NECK			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Shoes/Boots/ari.rsi

State	Old	New	Status
equipped-FEET			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Shoes/Boots/belpero.rsi

State	Old	New	Status
equipped-FEET			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Shoes/Boots/highheelshoes.rsi

State	Old	New	Status
equipped-FEET			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/alt_purplebartender.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/cap_turtleneck.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/cargoformal.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/centcom_officer.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/centcom_official.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/clown_distinguished.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/coroner.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_gothic.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_maid.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_red.rsi

State	Old	New	Status
equipped-INNERCLOTHING-avali			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_tango.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_victorian_black.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_victorian_red.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/elegantmaid.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/hop_turtleneck.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/hos_black.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/journalist.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/lady.rsi

State	Old	New	Status
equipped-INNERCLOTHING-avali			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/mining.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pastry.rsi

State	Old	New	Status
equipped-INNERCLOTHING-avali			Added
equipped-INNERCLOTHING-hydrakin			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_centcom_official.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_special_operations_officer.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_tan.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/performer_clown.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/performer_mime.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/rainbow.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/rd_classical.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/reporter.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvage.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvageformal.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvagelead.rsi

State	Old	New	Status
equipped-INNERCLOTHING-hydrakin			Added
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/schoolskirt.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/scientist_formal.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/suit_nurse.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/ari.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/belpero.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/cap_turtleneck.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-reptilian			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/captainnoble.rsi

State	Old	New	Status
equipped-INNERCLOTHING-felionoid			Added
equipped-INNERCLOTHING-resomi			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING-vulpkanin			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/cargo.rsi

State	Old	New	Status
equipped-INNERCLOTHING-monkey			Added
equipped-INNERCLOTHING-vox			Added
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added

Edit: diff updated after 296ae35

[mnva0]

Okay, little review. Thank you for this PR! I tested 100/493 files on multiple different species, including monkeys and all their directional sprites. Sorry about not reviewing that much in one go; something came up and I urgently need to hyperfocus on that.

Unlike my other large reviews, my review notes are not currently in a publishable state. I do not have the time to clean them up. I'll do that when I have time

You may want to remove the space after the X so GitHub formats your checkboxes. Like this

• a

Also, the changelog is for the players to read, not entirely for us. See the #changelog channel (where these get published) on the Discord for examples. Please write a (brief! can't include everything) player-facing summary of what's been added

You should have also likely included your testing media higher up. I don't know how the changelog bot will behave with the images at the bottom instead of the media section

[mnva0]

Thank you for making some changes! I read a couple more files. We're not supposed to use other SS14 servers' namespaces like this I think? Starlight likely did not make most of these changes, they were compatibility additions made for the Triad server

I booted up my developer environment to review more files, but was stopped by this fatal error. I'm not sure if the client I'm using is just making things up or something. It's probably something to do with meta.json somewhere
[FATL] unhandled: System.Collections.Generic.KeyNotFoundException: The given key 'equipped-HELMET-cyclorite' was not present in the dictionary.

[pandoraberry]

Push is because I fucked up somewhere with the ID renaming. Gonna look at this tomorrow with fresh eyes.

[pandoraberry]

More on the updates here
-Removed SL, WFSL and WF prefixes.
-Fixed up typos and weird AI generated descriptions. If you see more, put here and we'll change them.

As for the displacement issues, they seem incredibly widespread and there is no current PR's on Starlight or other branches addressing them.

I will be creating a separate PR to address those.

Incomplete, but I did fix the Salvage Lead's issues with most species except Resomi.
Black Fur Cloak is now fitted for Hydrakin and does not blind them.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[pandoraberry]

More on the updates here -Removed SL, WFSL and WF prefixes. -Fixed up typos and weird AI generated descriptions. If you see more, put here and we'll change them.

As for the displacement issues, they seem incredibly widespread and there is no current PR's on Starlight or other branches addressing them.

I will be creating a separate PR to address those.

Incomplete, but I did fix the Salvage Lead's issues with most species except Resomi. Black Fur Cloak is now fitted for Hydrakin and does not blind them.

So, I changed my mind on separating. I think having it all in one works because it's addressing all the rendering issues for the species brought up.

I've merged when I have so far here which is new inhand sprites, the skirtDisplacement component, Avali fixes and a test of the Hydrakin sprite.

[rebaserHEAD]

So I'll say in the future I'd probably divvy this up in to multiple smaller to ingest PRs. Going through this workload as an individual for testing can be a legitimate grindy nightmare.

I'm going to do a secondary audit of this hopefully this weekend? I might need our interim spritainers to also look this over to get their input on it. But yeah, you didn't do anything wrong! Just would recommend divvying these sorts of things up in to "collections" in the future so they're a little less stressful. Especially when it comes to sprite related stuff the process of going through them can be INCREDIBLY tedious.

[pandoraberry]

So I'll say in the future I'd probably divvy this up in to multiple smaller to ingest PRs. Going through this workload as an individual for testing can be a legitimate grindy nightmare.

I'm going to do a secondary audit of this hopefully this weekend? I might need our interim spritainers to also look this over to get their input on it. But yeah, you didn't do anything wrong! Just would recommend divvying these sorts of things up in to "collections" in the future so they're a little less stressful. Especially when it comes to sprite related stuff the process of going through them can be INCREDIBLY tedious.

Ah! Sorry. I think I'll be putting this one to draft so I can fully separate the changes when I have the time.

[rebaserHEAD]

No no yiu are good! Just in the future. We can deal with this one! :)