Hyper-Convection Upgrade Paused on Space - #307
Conversation
github-actions
Bot
added
size/S
S: Untriaged
C#
FTL
Triad-Sector
changed the title
|
Also fix the code on not getting every single god damn lathe then loop it for every fucking second. |
Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
|
God I hate checking this again to see if it works or not, should works NOW |
FINALLY, IT'S FIXED |
This is really cool but if you get a room in a loop of heating itself, it can be both exposed to space but have like .3 mols of air and continue to print o3o |
mrow o3o
|
Hmmm... fuck |
mnva0
left a comment
mnva0
left a comment
There was a problem hiding this comment.
They should call me Nitpickerva the way I
|
|
||
| # Mono | ||
| lathe-heat-producing-too-hot = [color=red]It is too hot![/color] | ||
| lathe-heat-producing-extreme-temperature = [color=red]Paused due to extreme temperature[/color] |
There was a problem hiding this comment.
Consistency with other lathe texts
| lathe-heat-producing-extreme-temperature = [color=red]Paused due to extreme temperature[/color] | |
| lathe-heat-producing-extreme-temperature = [color=red]Paused due to extreme temperature[/color]. |
| public TimeSpan UpdateSpacing = TimeSpan.FromSeconds(1); | ||
|
|
||
| // used for examine | ||
| // Triad start |
There was a problem hiding this comment.
This is unclosed and would be better off as an inline comment I think
rebaserHEAD
left a comment
rebaserHEAD
left a comment
There was a problem hiding this comment.
More or less good! Plz round these changes up and it looks good to me from there!
| if (!HasComp<LatheProducingComponent>(uid)) | ||
| continue; | ||
|
|
||
| var heatPerTile = heatComp.EnergyPerSecond / _environments.Count; |
There was a problem hiding this comment.
Dropping the HasComp<LatheProducingComponent> gate makes every idle hyperlathe (and the Forge) dump its full EnergyPerSecond into the room even when not producing. Doesn't look intentional.
| var heatPerTile = heatComp.EnergyPerSecond / _environments.Count; | |
| if (!HasComp<LatheProducingComponent>(uid)) | |
| continue; | |
| var heatPerTile = heatComp.EnergyPerSecond / _environments.Count; |
| // Triad start | ||
| [DataField] | ||
| public bool IsHot = false; | ||
| public bool IsExtremeTemp = false; | ||
| // </Mono> |
There was a problem hiding this comment.
The rename changes the serialized name too: a ship saved with a hot lathe carries isHot: true and errors on load after this merges. Keeping the wire name covers it, and tidies the markers while we're here.
| // Triad start | |
| [DataField] | |
| public bool IsHot = false; | |
| public bool IsExtremeTemp = false; | |
| // </Mono> | |
| [DataField("isHot")] // Triad: renamed from IsHot, wire name kept so saved ships load | |
| public bool IsExtremeTemp = false; | |
| // </Mono> |
5 participants
About the PR
Fixes the hyperlathe working on space
Why / Balance
By the code, it should do that somehow it doesn't.
Media
Requirements
How to test
Breaking changes
Changelog
🆑