use jshooks-api in contractjs/tests#49
Open
tequdev wants to merge 6 commits intoTransia-RnD:jshooksfrom
Open
Conversation
tequdev
commented
Aug 1, 2024
| @@ -1,5 +1,5 @@ | |||
| const Hook = (arg) => { | |||
| return accept('', 0) | |||
| return accept('base: Finished.', 0) | |||
Contributor
Author
There was a problem hiding this comment.
hooks-toolkit-ts/test/integration/hooks/toolbox/base.js.test.ts
Lines 64 to 66 in 628f682
Member
|
Those tests are actually going to be removed. They are for testing the c++ code. If they compile its not a big deal but the c++ does not have access to the jshooks-api so imo these need to be standalone. The other changes I do like though. |
Contributor
Author
If they are finally removed, that's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
Before / After
Test Plan