refactor: extract authentication into auth module - #22
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
Move resolve_auth, base64_encode, and Authorization header builders (plus their unit tests) out of confluence.rs into src/auth.rs. Re-export resolve_auth from confluence for existing callers. Fixes Toyota#21 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
takeoverjp
requested changes
Aug 24, 2026
takeoverjp
left a comment
takeoverjp
left a comment
Contributor
There was a problem hiding this comment.
@VedantMadane
Thank you for your contribution! 🎉
This PR breaks mise run ci.
Could you please check it?
https://github.com/Toyota/confluence2md/actions/runs/32652938814/job/97442643414?pr=22#step:4:153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract authentication-related implementation from
confluence.rsinto a dedicatedauthmodule (#21).Changes
src/auth.rswithresolve_auth,base64_encode,auth_headers,binary_auth_headersresolve_authfromconfluencesomain.rsimports stay stableARCHITECTURE.mdFixes #21