refactor: refactor http usage#85
Merged
null8626 merged 5 commits intoTop-gg-Community:masterfrom Sep 16, 2025
Merged
Conversation
velddev
approved these changes
Sep 16, 2025
Contributor
|
LGTM, why do all the tests always seem to break? |
Member
Author
|
If you were referring to the checks here, older Python versions are no longer supported by Otherwise, I'm unsure really. |
Member
Author
Fixed with #86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following pull request is a toned down version of #79. This pull request refactors the usage of HTTP requests by:
ClientSessionargument passed in the constructor is never used.default_bot_idargument to the main client..codeattribute inHTTPExceptionbeing randomly unassigned (NOTNone.)Newer features will be implemented in a future pull request once this is merged.