Skip to content

fix(mirror): regenerate stale mirror patches and stop flagging unused variants - #16

Merged
TonybynMp4 merged 2 commits into
mainfrom
fix/mirror-stale-patches
Sep 23, 2026
Merged

TonybynMp4 merged 2 commits into
mainfrom
fix/mirror-stale-patches

Conversation

@TonybynMp4

Copy link
Copy Markdown
Owner

The nightly build for v0.0.43-nightly.20260923.2150 failed on 0006-mirror-release-changelog.patch (#15). The patch's pre-image blob for SidebarUpdateReleaseNotes.tsx was never pushed; it only existed in local checkpoint refs. CI's depth-1 fetch therefore couldn't 3-way merge it. The plain-apply fallback then failed on upstream pingdotgg#13207, which changed the Separator class in the context lines.

  • Regenerated 0006 against main. Its content is unchanged apart from that one context line.
  • Regenerated 0001–0003 against main too. They still applied, but their pre-image blobs had also fallen off main, so they were one upstream edit away from the same failure. Only index lines and hunk offsets change.
  • report-stale-patch.sh now treats NNNN variants as alternatives, like apply-mirror-patches.sh does. The issue listed the unused 0003-…wslprebuild and 0004-…appidentity variants as stale even though their groups applied fine.

Verified in a CI-shaped shallow clone of the tag plus a depth-1 fetch of this branch. All six patches apply with a real 3-way merge, with no "lacks the necessary blob" errors. With the old 0006 staged and gh stubbed, the report script lists only 0006.

After merging, re-run Mirror Linux build for v0.0.43-nightly.20260923.2150.

Closes #15

🤖 Generated with Claude Code

TonybynMp4 and others added 2 commits September 23, 2026 16:14
…sed variants

0006 was generated against a sidebar blob that only existed locally, so CI's
depth-1 fetch could not 3-way merge it and the plain fallback broke on
upstream pingdotgg#13207's Separator change. Regenerated against main.

The stale-patch report now treats NNNN variants as alternatives, like the
apply script, instead of listing the unused variant of a working group.

Closes #15

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0001-0003 still applied, but their pre-image blobs had fallen off main, so
CI's depth-1 fetch could only plain-apply them and the next upstream edit
near a hunk would break them. Regenerated against main; hunk content is
unchanged, only index lines and offsets move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TonybynMp4
TonybynMp4 merged commit 197be29 into main Sep 23, 2026
3 checks passed
@TonybynMp4
TonybynMp4 deleted the fix/mirror-stale-patches branch September 23, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror patch no longer applies to v0.0.43-nightly.20260923.2150

1 participant