Keypad nodes-display item #1082
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 263bdd0.
2 tasks
Lwmte
reviewed
Feb 7, 2026
| ["Click"] = 644, -- TR2_Click | ||
| } | ||
|
|
||
| local function keypadCreate(object, code) |
Collaborator
There was a problem hiding this comment.
Please use PascalCase for function names, regardless of local/global scope.
| LevelFuncs.Engine.Node.KeypadCreate = function(object, code, volume) | ||
| LevelVars.Engine.Keypad.ActivatedKeypad = nil | ||
|
|
||
| local inventoryDelay = 0 |
Collaborator
There was a problem hiding this comment.
Do we need to keep all these variables and a soundmap outside functions? Node script format was nice in a way it contained necessary code only within node functions. By exposing variables/tables in this way, we are breaking this format. Not saying it is wrong, just something I never planned to be done, because node functions were meant to be a wrapper for lua functions that can be directly used in scripts.
Collaborator
Author
There was a problem hiding this comment.
I can move them in. I moved them out cause they would be created every frame but that’s ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised Keypad nodes.
Setup is simpler and now only requires one node.
Uses Display Item Class and to be merged after it.
Adds two new nodes. One to input, other to check the input.
TombEngine/TombEngine#1789