Skip to content

test: distinguish thread parent links from latest navigation - #244

Merged
LIghtJUNction merged 1 commit into
mainfrom
fix/thread-parent-selector-20261014
Oct 14, 2026
Merged

LIghtJUNction merged 1 commit into
mainfrom
fix/thread-parent-selector-20261014

Conversation

@LIghtJUNction

Copy link
Copy Markdown
Contributor

Scope

Test-only correction based on main 5a38844190cba78e493acb62e82dd3d1edd4fb04. No production behavior changes.

Rewrite contracts run 38402493342, shard 0 failed at tests/test_thread_tree_http.py:61 with the branch present and its child absent from the continuation page. The assertion searches all HTML for the branch anchor, but the renderer also uses that anchor for the legitimate “最新回复” navigation link.

  • Limit the parent-link assertion to class="thread-parent".
  • Add a deterministic renderer regression with a visible, latest branch and an off-page child. Assert the latest-reply navigation remains present while no child-to-parent link exists.
  • Preserve the existing latest-reply navigation coverage.

This diagnoses an overly broad test assertion; it does not claim a production pagination defect.

Verification and limits

  • Executed the exact pinned thread_tree and thread_fragment_html functions in an isolated harness, with unrelated display helpers stubbed.
  • Reproduced failure of the old broad assertion; the specific parent-link selector passed.
  • The new deterministic regression and the existing latest-reply navigation assertions passed in that harness.
  • Parent+child visible, missing-parent, and missing-child combinations passed.
  • Python syntax compilation and patch applicability checks passed.
  • Available local Python is 3.12/3.13, while this project requires >=3.15. Full HTTP/PostgreSQL pytest and Ruff were not run. The isolated harness is not a substitute for those checks.

Draft for review and project-toolchain validation. No manual CI dispatch, merge, release or deployment.

Coordination

The repository workflow was read. No usable authorized private MSG task-parent reference was available for this review, so coordination used the existing task channel rather than creating another production identity or widening credentials.

@LIghtJUNction
LIghtJUNction marked this pull request as ready for review October 14, 2026 07:21
Copilot AI balanced review requested due to automatic review settings October 14, 2026 07:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-14T07:24:53.151238Z e2fc1d7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LIghtJUNction
LIghtJUNction merged commit c1e5a0f into main Oct 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants