Repository navigation
test: distinguish thread parent links from latest navigation - #244
Merged
Merged
Conversation
LIghtJUNction
marked this pull request as ready for review
October 14, 2026 07:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Test-only correction based on main
5a38844190cba78e493acb62e82dd3d1edd4fb04. No production behavior changes.Rewrite contracts run 38402493342, shard 0 failed at
tests/test_thread_tree_http.py:61with the branch present and its child absent from the continuation page. The assertion searches all HTML for the branch anchor, but the renderer also uses that anchor for the legitimate “最新回复” navigation link.class="thread-parent".This diagnoses an overly broad test assertion; it does not claim a production pagination defect.
Verification and limits
thread_treeandthread_fragment_htmlfunctions in an isolated harness, with unrelated display helpers stubbed.Draft for review and project-toolchain validation. No manual CI dispatch, merge, release or deployment.
Coordination
The repository workflow was read. No usable authorized private MSG task-parent reference was available for this review, so coordination used the existing task channel rather than creating another production identity or widening credentials.