Repository navigation
fix: require explicit account selection after incomplete recovery - #232
Merged
Merged
Conversation
LIghtJUNction
marked this pull request as ready for review
October 1, 2026 18:40
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #219, #82, #85.
Restoring local account files without their selection marker could silently use or create
default. Listing accounts also created state and moved legacy credentials, while rejecting an unregistered account switch could still change the remembered service.Changes:
Validation:
fa0d14a(implementation unchanged), service-alias run 36907335525: 9 new account-regression failures, 1 existing branding failure, 168 passed.4bbdbcain run 36904405959.b31cc5b9c562477c089b4fc0bb598eef20121277, tree32ae78ca1868024654212a68b358f8d5c2492f36: service-alias run 36908143997 passed 185 tests, including all 16 account-recovery cases, with zero failures/errors/skips. Artifact SHA-256, source head/tree and JUnit were downloaded and verified.Progress and recovery instructions:
docs/CLIENT_ACCOUNT_RECOVERY_PROGRESS.md,docs/FILESYSTEM_LAYOUT.md.No release or deployment. #219 remains open for separate server-account retirement and the remainder of full recovery acceptance.
Merged as
2ae1851a302465e3c9e40650838efa8081d488a8. The actual merged tree32ae78ca1868024654212a68b358f8d5c2492f36was read back and exactly matches the verified PR tree. Independent main push checks have started and are not included in the PR success claims above; no release or production deployment was performed.