Repository navigation
fix: prevent system notifications from breaking the inbox - #231
Merged
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Todo reminders and bounty settlement notifications deliberately store
sender=None. Mailbox contact projection passes that value into resource authorization, which returnsnot_foundand makes the entire inbox fail, including browser requests.Changes
System notification, without inventing an account or looking up a resource.Verification
Before the fix, run 36886410271 reproduced the browser 404 and both existing notification failures. The new contact privacy fixtures initially used a one-line body that the preview contract treats as a title; they now supply an explicit heading and a separate excerpt. No privacy assertion was removed.
At head
7cb34aa, focused run 36887249063 passed all mailbox regressions: 37 passed, with the sole remaining failure precisely identified as private-agent discovery returningquery_cost_exceeded. This was intermittent in the old limit-200 query. The follow-up pagination change addresses that failure while checking the entire result set and a positive public control.At that previous head, quality (702 files, zero Ruff diagnostics), installed client/server rehearsal, recovery, architecture, storage, hosting, credentials, aliases and chunk-size checks passed on merge
d18279e/ tree255ecd24a568dd7ce3d241cfdd30b715048a18b7. Final-head CI is rerunning; previous-head results are not presented as final-head evidence.Refs #81, #82, #85. This is a code-level regression fix, not closure of those broader acceptance issues. No production deployment, account archival, Root operation, or external notification delivery.