Repository navigation
Fix read-only hosting startup with feature-aware contracts - #226
Merged
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read-only hosting process crashes during registry construction after identity-renaming registration began reading the configured feature flag: its registration context includes a registry but no settings. Give contract registration the same immutable settings snapshot as the reader. Business handlers and requirements are still replaced by contract-only functions; no signer, write store, executor or parent Application is added.
This fixes the actual
test_idle_readonly_hosting_requires_restart_without_expanding_rolefailure observed in both C and en_US integration CI on PR #222. The other jobs passed.Validation: all 25 existing read-only hosting and recovery-runtime tests passed against real PostgreSQL roles, including source/catalog agreement, write denial, no signer/business closures, hosted-file delivery and the previously failing restart case. Ruff check/format and diff checks passed. Rebased over the subsequent README/runbook-only commits onto main 86bd2f1 without changing the tested source. No deployment or production migration.