Skip to content

Preserve homepage read contracts and align installed restore checks - #206

Merged
LIghtJUNction merged 3 commits into
mainfrom
fix/home-summary-fixtures-20261001
Sep 30, 2026
Merged

LIghtJUNction merged 3 commits into
mainfrom
fix/home-summary-fixtures-20261001

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Recent homepage and filesystem changes broke published read-query contracts and installed acceptance checks. Adding home_summary to discovery.read_query@1 changed an already published short-code dictionary row; HTTP boundary stubs still expected the old homepage operation, and the restore rehearsal removed a marker from its former config-directory path.

Preserve the published v1 schema and move the anonymous-only summary into discovery.read_query@4, accepting only home_summary=True. The homepage requests v4 explicitly. Generic short-code reads now preserve their decoded contract version and reject a header packet bound to a different version. Existing credential ceilings are not expanded.

Align the two strict HTTP stubs with the current summary request. Resolve the restored quarantine marker through Settings.recovery_marker, require that it exists, and retain both marker-present and marker-removed quarantine checks. No workflow configuration or published short-code data is changed.

Validation:

  • HTTP fixture baseline reproduced 8 failures; fixture/nginx/branding/username regressions then passed (161 tests).
  • Final versioned summary, published dictionary, identity keys, URL secrets, homepage and nginx checks passed (189 tests); all remaining failing cloud entry points passed (9 tests); v4 direct HTTP plus wrong-version binding and existing signed-header checks passed (4 tests).
  • Built 0.2.0 wheel with locked server dependencies in a separate environment and ran the complete installed-server rehearsal using -I outside the checkout: all 12 checks passed, including backup/restore conservation and quarantine after marker removal; temporary installation removed, zero external recipients.
  • Full Ruff lint and formatting passed. Merge waits for all current-head cloud checks.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 17:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@LIghtJUNction LIghtJUNction changed the title Align homepage boundary fixtures with read-query authority Align homepage and installed restore rehearsals with current contracts Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

CI verification for cbbf1c1: the installed-server deployment rehearsal passes, and the nginx/request-target fixture tests no longer return the previous homepage 500s. These results cover both fixes in this PR.

The full run is still red: Rewrite contracts reports 37 failed / 2,814 passed tests. The remaining failures trace to the inherited published discovery.read_query@1 contract drift (published_operation_changed, including downstream dictionary/HTTP assertions), not these fixture or marker-path changes.

Deployment: https://github.com/TokenNotIncluded/msg.lmm.best/actions/runs/36751130916
Rewrite contracts: https://github.com/TokenNotIncluded/msg.lmm.best/actions/runs/36751130933

@LIghtJUNction LIghtJUNction changed the title Align homepage and installed restore rehearsals with current contracts Preserve homepage read contracts and align installed restore checks Sep 30, 2026
@LIghtJUNction
LIghtJUNction merged commit 5688012 into main Sep 30, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants