Repository navigation
Preserve CLI formatting on ReadQuery cursor continuation - #198
Merged
Merged
Conversation
Contributor
Author
|
最终 head 完整回归 36726438857：8 个 shards 与最终 contracts success；8 份 ZIP 均下载并核对 SHA-256，manifest/JUnit 精确 node-ID 为完整互斥并集 2723 core + 8 conformance，零 failure/error/skipped。新增 14 项 cursor 用例全部通过。扩展的真实签名 HTTP/PostgreSQL 测试已验证 jq/template 续页、原始 cursor/version 保持与全表零写入，shard 3 实际用时 5.974s。 严格质量 与安装包隔离演练 同样成功。此前本地空 cursor/null/非字符串拒绝修复已在最终树中，没有删断言或跳过用例。 保持 draft，尚未合并；这完成本次 cursor-formatting 切片的代码验收，不表示 #82 全部完成，也不涉及生产部署。自动分页仍未加入本 PR。 |
LIghtJUNction
marked this pull request as ready for review
September 30, 2026 15:59
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #82. Narrow follow-up to #197; no automatic pagination or global shortcut changes.
The first output slice required --json fields for jq/template formatting while correctly refusing --json with a cursor, which left later pages unformattable. Allow formatting of canonical discovery.read_query cursor-only continuation without resending its projection. Recheck the exact schema name, version and read effect before signing the unchanged cursor request; preserve unsuccessful schema responses and the original cursor/version rules.
Reject other operations, mixed cursor/query fields, --return-field conflicts, and empty/non-string cursors before network access. The empty-cursor guard prevents a continuation request from being interpreted as a fresh default-projection first page. Existing explicit first-page --json behavior stays unchanged.
Validation: 7 initial regression failures before implementation; independent review then found the empty-cursor case, reproduced with 3 additional failures and fixed. Final 50 pure output tests and 61 related client/TUI tests pass locally. Full Ruff/616-file format/Python 3.15 warnings-as-error compile, pinned wheel/sdist build and package-content verification pass after refresh. Expanded real signed HTTP/PostgreSQL test exercises formatted continuation and all-row read conservation; local DB sockets are restricted, so this and complete CI remain pending rather than claimed passed.
Base 523552b; head 88688d0; tree 8f4a187a64c2d09bf9afbb5d693d86cc49b62c90. Current main's unrelated package/web changes are preserved unchanged. Exactly 5 files differ. Draft for review and CI only; no merge, production deployment, or #82 closure.