Repository navigation
fix: close Windows profile isolation review findings - #2
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation addresses Windows casing behavior and is supported by focused cross-version tests.
Review effort: Balanced
Findings: None
What changed in this PR
Improves child-process environment isolation, particularly on Windows.
Changes:
- Removes provider overrides case-insensitively without mutating the source environment.
- Adds unit and child-process coverage on Windows with Node.js 22 and 24.
- Blocks uppercase and lowercase proxy variants in native-host tests.
| File | Description |
|---|---|
src/provider.mjs |
Makes provider-variable filtering case-insensitive. |
test/child-environment.test.mjs |
Tests casing removal, preservation, and child isolation. |
test/native-host.mjs |
Overrides lowercase proxy variables. |
.github/workflows/windows-environment.yml |
Runs isolation tests on Windows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1 before accepting the parent plugin update.
Addresses review threads discussion_r4195652941 and discussion_r4195653018, and parent TokenNotIncluded/lmm-api#601 discussion_r4195708320.
No production OAuth, inference, publication or deployment. Merge after the existing adapter/native-host and new Windows checks pass.