-
-
Notifications
You must be signed in to change notification settings - Fork 105
Feat/help thread stats #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feat/help thread stats #1361
Conversation
replaces fetching metrics directly from database instead of discord, uses embed for showcases stats and making duration as optional choice in terms of days
spotless fixes, helper for calculating duration in seconds between datetime fields to be more compliant with code quality tests
change emojis to unicode character constants with descriptive names, single/blank line of space to be more intentional and clear
tj-wazei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, just some small changes to the imports.
| import org.togetherjava.tjbot.features.filesharing.FileSharingMessageListener; | ||
| import org.togetherjava.tjbot.features.github.GitHubCommand; | ||
| import org.togetherjava.tjbot.features.github.GitHubReference; | ||
| import org.togetherjava.tjbot.features.help.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No star imports please.
| import java.time.temporal.ChronoUnit; | ||
| import java.util.Objects; | ||
|
|
||
| import static org.jooq.impl.DSL.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No star imports please.
continues work of #1159 with /help-stats slash command, refactors to fetch stats from database instead of discord APIs. Also adds stats to embed for better UX.
embed color has three states