Conversation
ci.yml installs no optional extras on purpose: the default path must stay installable with zero system dependencies, and proving that means never installing them there. The cost of that decision was never paid — extras.yml was written into ci.yml's header comment as "still to come" and never built. So 28 ui-marked tests and the whole SynthID matrix were green locally and executed in no CI environment at all. A whole probe kind and the check the README calls the one no other tool performs. That is a slower version of a job that runs three echo statements, and it is the second time this repository has had one. Nightly, because both are genuinely slow — Playwright downloads a browser, transformers loads a tokenizer — and a break in an optional surface can wait a day. Also on any pull request touching the code these tests are the only cover for, so a change to the UI probe or the detector does not wait for the night. The third job is the lesson from the determinism placeholder: a marker that selects nothing leaves two green jobs proving nothing, and pytest exits 5 on "no tests collected", which reads like success to a workflow that does not look. It fails if either marker drops below five tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.ymlinstalls no optional extras on purpose — the default path has to stayinstallable with zero system dependencies, and proving that means never installing
them there.
The cost of that decision was never paid.
extras.ymlwas written into ci.yml'sown header comment as "still to come" and never built:
So 28 ui-marked tests and the entire SynthID matrix executed in no CI
environment at all — a whole probe kind, and the check the README calls the one
no other tool performs against a live endpoint. Green locally, unrun everywhere
else.
That is a slower version of a job that runs three
echostatements, and it is thesecond time this repository has had one.
What runs now
uiplaywright install --with-deps chromium, thenpytest -m uisynthidpytest -m synthidwith the extra, tokenizer cachedguardNightly, because both are genuinely slow and a break in an optional surface can
wait a day — plus on any pull request touching the code these tests are the only
cover for, so a change to the UI probe or the detector does not wait for the
night.
The third job is the lesson
A marker that selects nothing leaves two green jobs proving nothing, and
pytestexits 5 on "no tests collected" — which reads like success to a workflow that
does not look. Renaming a marker or deleting the last test carrying it would
otherwise reproduce exactly the failure this repository already had once.
Both markers currently select 28 tests.
🤖 Generated with Claude Code