Skip to content

Add refHash support for transaction hash replay in SimulationResultsPage and TransactionSummary#16

Merged
Timidan merged 1 commit into
masterfrom
fix/logo-refhash
May 28, 2026
Merged

Add refHash support for transaction hash replay in SimulationResultsPage and TransactionSummary#16
Timidan merged 1 commit into
masterfrom
fix/logo-refhash

Conversation

@Timidan

@Timidan Timidan commented Apr 23, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 14:00
@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3-toolkit Ready Ready Preview, Comment Apr 23, 2026 2:00pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Timidan

Timidan commented Apr 23, 2026

Copy link
Copy Markdown
Owner Author

@copilot review

Copilot AI commented Apr 23, 2026

Copy link
Copy Markdown

@copilot review

Here's a review of the three changes in this PR:

SimulationResultsPage.tsx

  • The refHash derivation is well-guarded — it's only set when the simulation origin is "tx-hash-replay" and the replayed hash differs from the simulation ID (avoiding a duplicate row). ✅
  • simulationOrigin and replayTxHash are already part of the base SimulationContractContext interface, so no unsafe type-cast is needed — cleaner than the existing contextWithExtras pattern. ✅

TransactionSummary.tsx

  • refHash is correctly optional with a clear JSDoc comment. ✅
  • The "Ref Hash" row renders directly below the "Hash" row with a copy button — sensible placement and consistent with the rest of the summary grid. ✅

TopBar.tsx

  • Replacing <div> with <Link to="/"> is minimal and correct. react-router-dom is already a project dependency. ✅
  • aria-label="HexKit home" and focus-visible:ring classes are good accessibility additions. ✅

No issues found — the implementation is correct and consistent with existing patterns in the codebase.

@Timidan Timidan merged commit bb3caf2 into master May 28, 2026
7 checks passed
@Timidan Timidan deleted the fix/logo-refhash branch June 1, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants