Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"
authors = [{ name = "chatos@alibaba" }]
requires-python = "<4.0,>=3.10"
name = "rl-rock"
version = "1.10.0.dev20"
version = "1.10.0.dev2026070901"
description = "ROCK-Reinforcement Open Construction Kit"
readme = "README.md"
dependencies = [
Expand Down
2 changes: 1 addition & 1 deletion rock/sdk/mcp/mcp_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ async def init(self, data: dict) -> dict:
result = self.data_lifecycles[lifecycle_type].init(lifecycle_data)
if inspect.isawaitable(result):
result = await result
if result is not None and result != {}:
if result is not None:
init_results[lifecycle_type] = result
return init_results

Expand Down
16 changes: 16 additions & 0 deletions tests/unit/sdk/mcp/test_mcp_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ def init(self, data: dict) -> dict:
return {"initialized": False, "result": {}}


class EmptyInitResultLifecycle(RecordingDataLifecycle):
def init(self, data: dict) -> dict:
super().init(data)
return {}


class FakeSandboxAware:
def set_sandbox(self, sandbox) -> None:
self.sandbox = sandbox
Expand Down Expand Up @@ -715,6 +721,16 @@ def test_mcp_env_init_keeps_deferred_init_result(monkeypatch):
assert result == {"slack": {"initialized": False, "result": {}}}


def test_mcp_env_init_keeps_empty_lifecycle_result(monkeypatch):
mcp_env = reload_mcp_env(monkeypatch)
env = mcp_env.McpEnv(servers={"slack": slack_server_config()})
env.data_lifecycles["slack"] = EmptyInitResultLifecycle()

result = asyncio.run(env.init({"slack": {"reset": []}}))

assert result == {"slack": {}}


def test_mcp_env_dump_awaits_async_lifecycle(monkeypatch):
mcp_env = reload_mcp_env(monkeypatch)
env = mcp_env.McpEnv(servers={"slack": slack_server_config()})
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading