Alphabet fixes #24
Open
Alphabet fixes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using maximum height of all letters in font it only uses the heights ot the line!
BaranMuzu
changed the title
TechnikTil
added
PR: Haxe
TechnikTil
requested changes
Jan 20, 2026
Member
TechnikTil
left a comment
TechnikTil
left a comment
There was a problem hiding this comment.
Baran, this is great for your first PR! There are some small nitpicks/issues though.
| for (line in realLines) | ||
| { | ||
| // Skip it if the line is fully empty | ||
| if (line.length == 0 && realLines.indexOf(line) == realLines.length - 1) |
Member
There was a problem hiding this comment.
Suggested change
| if (line.length == 0 && realLines.indexOf(line) == realLines.length - 1) | |
| if (line.length == 0) |
I don't see why we would check if this is in the last array... If this is intentional, say it in the comment.
Author
There was a problem hiding this comment.
after realLines is created for me there was a extra array that had nothing at all if i didn't mess up it suppose to clear that extra array
Member
There was a problem hiding this comment.
fair...
what exactly would happen if this check didnt exist?
Author
There was a problem hiding this comment.
didn't check but it might move the text up slightly
not sure of course- i still don't understand how haxe works
Co-authored-by: TechnikTil <techniktil@tilnotdrip.org>
Co-authored-by: TechnikTil <techniktil@tilnotdrip.org>
Co-authored-by: TechnikTil <techniktil@tilnotdrip.org>
Co-authored-by: TechnikTil <techniktil@tilnotdrip.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request makes that alphabet hx using maximum heights of the current line instead of all letters in the font
and fixing the title state intro text collising the newgrounds logo