Skip to content

Updated the dead maven repo#9

Merged
TigerHix merged 9 commits into
TigerHix:masterfrom
jingwenMC:master
Dec 28, 2022
Merged

Updated the dead maven repo#9
TigerHix merged 9 commits into
TigerHix:masterfrom
jingwenMC:master

Conversation

@jingwenMC

Copy link
Copy Markdown
Contributor

The maven repo seemed to be dead. I've moved it to Jitpack and made several changes to make it usable again.

@dgrfps

dgrfps commented Dec 24, 2022

Copy link
Copy Markdown

THANKS FOR KEEPING IT ALIVE!

@TigerHix
TigerHix merged commit 370a17c into TigerHix:master Dec 28, 2022
@TigerHix

Copy link
Copy Markdown
Owner

Latest maven run failed:
https://github.com/TigerHix/ScoreboardLib/actions/runs/3797212336

@jingwenMC Could you help check why?

@dgrfps

dgrfps commented Dec 28, 2022

Copy link
Copy Markdown

Are you trying to upload the library to his repository?
the build error is on upload, I can't read the full log

@dgrfps

dgrfps commented Dec 28, 2022

Copy link
Copy Markdown

Yes that's probably it, check your action yml, it is trying to upload to his repository, which you don't have access

@TigerHix

Copy link
Copy Markdown
Owner

Reverted #9. Let me know when you have fixed the repo issue. For this public repo I don't think you should include a workflow action to upload to any repo.

Thanks @dgrfps for the heads up.

@dgrfps

dgrfps commented Dec 29, 2022

Copy link
Copy Markdown

No problem @TigerHix, i created a pull req in case you wan't to merge.
I compiled using compile & package script, both passing.
I setted maven/readme to use @jingwenMC repository.

@jingwenMC

Copy link
Copy Markdown
Contributor Author

Latest maven run failed: https://github.com/TigerHix/ScoreboardLib/actions/runs/3797212336

@jingwenMC Could you help check why?

It attempts to upload the artifact to my maven repo :(

@jingwenMC

Copy link
Copy Markdown
Contributor Author

Reverted #9. Let me know when you have fixed the repo issue. For this public repo I don't think you should include a workflow action to upload to any repo.

Thanks @dgrfps for the heads up.

It should be fixed in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants