Use UI.WPF.Modern to Implement Modern UI Design with Dark Mode Support #648
Conversation
Modified CheckBox bindings in ConversionPresetTemplates.xaml: - Removed `IsEnabled` bindings for two CheckBox elements. - Updated `IsChecked` binding to use `Mode=TwoWay` for one CheckBox. - Added `Margin="0,6,0,0"` to one CheckBox for improved layout.
Replaced DockPanel with a horizontally oriented StackPanel for audio settings at Grid.Row="5" and Grid.Column="0". Moved the CheckBox and Label elements into the new StackPanel for improved layout consistency. Updated the Label's VerticalAlignment to Center for better alignment. No functional changes were made to bindings or converters.
There was a problem hiding this comment.
Pull request overview
This pull request implements modern UI design with dark mode support by integrating the iNKORE.UI.WPF.Modern library (version 0.10.1) into the FileConverter application. The changes resolve issue #240, which requested dark mode functionality.
Changes:
- Integrated UI.WPF.Modern library to provide modern UI styling with theme-aware dark mode support
- Updated all window XAML files with modern window styling attributes including Mica backdrop effects
- Refactored color references and styles to work dynamically with both light and dark themes
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FileConverter.csproj | Added iNKORE.UI.WPF.Modern package dependency; removed Microsoft.Xaml.Behaviors.Wpf |
| Product.wxs | Updated installer components to include new UI.WPF.Modern DLLs; removed old Microsoft.Xaml.Behaviors entry |
| Application.xaml | Added UI.WPF.Modern theme resources and overrides for checkbox minimum width |
| MainWindow.xaml | Added modern window styling attributes and adjusted margins for new theme |
| SettingsWindow.xaml | Added modern styling with extended title bar, ScrollViewerEx for better scrolling, and layout improvements |
| UpgradeWindow.xaml | Added modern window styling and margin adjustments |
| HelpWindow.xaml | Added modern window styling with SizeToContent support and button stretch |
| DiagnosticsWindow.xaml | Added modern window styling and margin adjustments |
| CustomStyles.xaml | Commented out conflicting default styles; updated resource references to use theme-aware brushes |
| ConversionPresetTemplates.xaml | Updated color references to theme-aware resources; improved layouts for dark mode compatibility |
| ConversionJobControl.xaml | Adjusted foreground opacity values for better contrast across themes |
| EncodingQualitySliderControl.xaml | Updated color reference to theme-aware HyperlinkForeground brush |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageReference Include="Office"> | ||
| <Version>12.0.0</Version> | ||
| </PackageReference> |
There was a problem hiding this comment.
The Microsoft.Xaml.Behaviors.Wpf package has been removed from the project dependencies, but the code still uses it. The BindableSelectedItemBehavior.cs file explicitly imports "using Microsoft.Xaml.Behaviors;" and multiple XAML files use the "xmlns:behaviors="http://schemas.microsoft.com/xaml/behaviors"" namespace. Unless the iNKORE.UI.WPF.Modern package includes Microsoft.Xaml.Behaviors as a transitive dependency (which should be verified), this removal will cause build errors. If the iNKORE.UI.WPF.Modern does include it, please verify that the version is compatible with the existing code.
1 participant
Resolve #240