Skip to content

doc: Loosen the buddy group option field requirements #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rustybee42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: Loosen the buddy group option field requirements #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions go/management/management.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions go/management/management_protoopaque.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions proto/management.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ message DeletePoolResponse {

// Buddy groups

// New in 8.5.
message BuddyGroupOptions {
enum BuddyGroupQuotaAccounting {
BUDDY_GROUP_QUOTA_ACCOUNTING_UNSPECIFIED = 0;
Expand All @@ -312,7 +313,7 @@ message BuddyGroupOptions {
// The quota accounting mode for this buddy group.
// When used for setting options: Optional if the corresponding buddy group is a storage group,
// unset otherwise.
// When used for getting options: Required if the corresponding buddy group is a storage group,
// When used for getting options: Optional if the corresponding buddy group is a storage group,
// unset otherwise.
optional BuddyGroupQuotaAccounting quota_accounting = 1;
}
Expand Down Expand Up @@ -345,7 +346,7 @@ message GetBuddyGroupsResponse {
// set, should be completely populated.
optional beegfs.EntityIdSet storage_pool = 7;
// The options for this buddy group.
// Required.
// New in 8.5. Optional for compatibility.
optional BuddyGroupOptions options = 8;
}

Expand All @@ -371,7 +372,7 @@ message CreateBuddyGroupRequest {
// Required. One identifier is sufficient.
optional beegfs.EntityIdSet secondary_target = 5;
// The options for this buddy group.
// Required.
// New in 8.5. Optional for compatibility. Assume default values if unset.
optional BuddyGroupOptions options = 6;
}
message CreateBuddyGroupResponse {
Expand All @@ -381,6 +382,7 @@ message CreateBuddyGroupResponse {
}

// Modifies a buddy group or its config.
// New in 8.5.
message ModifyBuddyGroupRequest {
// The buddy group to modify.
// Required. One identifier is sufficient.
Expand Down
8 changes: 5 additions & 3 deletions rust/management.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,13 @@ pub struct DeletePoolResponse {
#[prost(message, optional, tag = "1")]
pub pool: ::core::option::Option<super::beegfs::EntityIdSet>,
}
/// New in 8.5.
#[derive(Clone, Copy, PartialEq, Eq, Hash, ::prost::Message)]
pub struct BuddyGroupOptions {
/// The quota accounting mode for this buddy group.
/// When used for setting options: Optional if the corresponding buddy group is a storage group,
/// unset otherwise.
/// When used for getting options: Required if the corresponding buddy group is a storage group,
/// When used for getting options: Optional if the corresponding buddy group is a storage group,
/// unset otherwise.
#[prost(
enumeration = "buddy_group_options::BuddyGroupQuotaAccounting",
Expand Down Expand Up @@ -430,7 +431,7 @@ pub mod get_buddy_groups_response {
#[prost(message, optional, tag = "7")]
pub storage_pool: ::core::option::Option<super::super::beegfs::EntityIdSet>,
/// The options for this buddy group.
/// Required.
/// New in 8.5. Optional for compatibility.
#[prost(message, optional, tag = "8")]
pub options: ::core::option::Option<super::BuddyGroupOptions>,
}
Expand Down Expand Up @@ -459,7 +460,7 @@ pub struct CreateBuddyGroupRequest {
#[prost(message, optional, tag = "5")]
pub secondary_target: ::core::option::Option<super::beegfs::EntityIdSet>,
/// The options for this buddy group.
/// Required.
/// New in 8.5. Optional for compatibility. Assume default values if unset.
#[prost(message, optional, tag = "6")]
pub options: ::core::option::Option<BuddyGroupOptions>,
}
Expand All @@ -471,6 +472,7 @@ pub struct CreateBuddyGroupResponse {
pub group: ::core::option::Option<super::beegfs::EntityIdSet>,
}
/// Modifies a buddy group or its config.
/// New in 8.5.
#[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)]
pub struct ModifyBuddyGroupRequest {
/// The buddy group to modify.
Expand Down
Loading