fix(c++): Remove c++ generation - #76
Merged
Merged
Conversation
C++ code must be generated using the exact same version of protobuf and gRPC that is used by the libraries using the code later. Since we want to depend on the distro packages to avoid doing the time and resource consuming manual build, these are different among the supported distibutions, so we can't have fixed generated code. Instead, the code generation step is moved to the configure/build stage of the consuming projects.
rustybee42
force-pushed
the
rb/cpp-proto
branch
from
August 13, 2026 13:53
e32bd11 to
30c6650
Compare
iamjoemccormick
approved these changes
Aug 27, 2026
iamjoemccormick
left a comment
iamjoemccormick
left a comment
Member
There was a problem hiding this comment.
Seems harmless since it sounds like nothing could / should use these anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ code must be generated using the exact same version of protobuf and gRPC that is used by the libraries using the code later.
If we ever use C++ gRPC at all, we most likely want to depend on the distro packages to avoid doing the time and resource consuming manual build. These are different among the supported distributions, so we can't have fixed generated code.
Instead, the code generation step must be done during the build step of the consuming projects (e.g. using cmake).