Skip to content

Fix "Too many open files" when migrating files with hard links #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robberteggermont wants to merge 1 commit into
base: 7.4.x
Choose a base branch
from
Open

Fix "Too many open files" when migrating files with hard links #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ctl/source/modes/migrate/MigrateFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,24 @@ bool MigrateFile::migrateRegularFile()
if (fromStatData.st_nlink > 1)
{
std::cerr << "Cannot migrate file with hard link (yet): " << this->filePath << std::endl;
close(fromFD);
return false;
}

auto maybeFromXAttrs(getXAttrs());
if (!maybeFromXAttrs)
{
close(fromFD);
return false;
}
XAttrMap fromXAttrs (std::move(*maybeFromXAttrs));

int tmpFD = runCreateIoctl(&fromStatData);
if (tmpFD < 0)
{
close(fromFD);
return false; // failed to create new file
}

bool metaRes;
int renameRes;
Expand Down