Conversation
#323) We have the default values in beegfs-copy for chunksize and partition threshold explicitly in the text, so don't show the (Default XYZ) text as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do / why do we need it?
beegfs copy --helpshowed the default value for--chunksizeand--partition-thresholdtwice: once in the flag's own description text, once via pflag's auto-generated(default N)suffix. Suppresses the redundant suffix by setting each flag'sDefValueto"0", which trips pflag's existingdefaultIsZeroValue()check (seespf13/pflag'sflag.go) that skips printing(default N)when the default is the type's zero value. The actual bound default (128MB / 1024MB) is unaffected --DefValueis a display-only string, separate from the flag's real value.Follows the same pattern already used in
ctl/internal/cmd/rst/pushpull.goforPriorityFlag.Verified: built and ran
beegfs copy --help-- output now shows only the explicit "Default chunk size: 128 MB." text, no more duplicate(default 128). Confirmed viagofmtandgo build/go vet(GOOS=linux) that nothing else broke.Related Issue(s)
#323
Where should the reviewer(s) start reviewing this?
Single 5-line change in
ctl/internal/cmd/copy/copy.go.Are there any specific topics we should discuss before merging?
Not required.
What are the next steps after this PR?
Not required.
Checklist before merging: