fix(skirmish): Improve determinism for restarted games by resetting slot values#2373
Draft
Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Draft
fix(skirmish): Improve determinism for restarted games by resetting slot values#2373Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Conversation
…andomized slot values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restarted skirmish games may not start with the same logical seed value as the first start. This depends on whether there are players with a random color / position / faction. This is resolved the first time by using and updating the logical seed, after which the random values are stored. That means that for restarted games the logical seed isn't used or updated. This PR resets those values to improve determinism for restarted games.
TODO: