refactor: Clean up the RandomValue code

[Caball009]

• Follow-up PR for bugfix(logic): Decouple scripted audio events from CRC computation #2075 (comment)

This PR cleans up RandomValue.cpp:

• Removes code that was commented out.
• Reorders functions so that they are in a consistent order (1 client, 2 audio, 3 logic).
• Makes the GetGame... functions resemble each other as much as possible.
• Adds assertions for random values that fall outside the min — max range.
• Optimizes the initialization of theMultFactor.
• Changes the early return logic for the GetGame... functions.
• Changes pass by pointer to pass by reference for the seed arrays.
• Changes a few minor miscellaneous things to improve consistency or formatting.