unify(pathfinder): Merge AIPathfind and update dependencies by Mauller · Pull Request #2341 · TheSuperHackers/GeneralsGameCode

Mauller · 2026-02-22T17:08:52Z

Merge by rebase

This PR merged Aipathfind.h and Aipathfind.cpp

The majority of the merge has required conditionals being placed throughout the code, this is due to significant changes between zero hour and generals making the function incompatible.

The majority of the merges are safe and distinct, either directly inherited from zero hour and into generals, or cleaned up from generals into zero hour.

The most involved the majority merge and refactor involves the functions within the PathfindZoneManager, as zero hour changes large portions of this code. The code itself was a mess and i reverted the implementation of parts of it from while back to for loops as used within generals to make the code easier to understand.

Generals inherited some optimisations from zero hour within PathfindZoneManager but had to retain the original code in other places due to mismatches occuring.

Generals gained the boolean returning versions of the terrain object handling functions, although the generals code does not specifically use them. This was done as a cleaner merge.

Generals also gained some zero hour functions that now check for nulls.
Generals also gained some functional name changes from zero hour which required updating call sites.

Zero hour gained some debugging that was lost from generals and some cleaned up implementation and formatting.

EDIT: I also had to extend an enum in generals' AI.h due to debug changes merged back from zero hour.

I split the unification into commits to make reviewing it easier, the most strenuous commit is the third commit of the PathfindZoneManager. This is where a considerable amount of satinising and refactoring occurred between both implementations.

EDIT - This merge is now muh cleaner after performing some cleanup to the Zero Hour implementation of PathfindZoneMAnager and the porting of optimisations from zero hour to generals.

greptile-apps · 2026-02-22T17:12:20Z

Greptile Summary

This PR successfully unifies the AIPathfind pathfinding system between Generals and Zero Hour, merging approximately 850 lines of code changes across 10 files. The unification primarily uses conditional compilation (#if RTS_GENERALS/#if RTS_ZEROHOUR) to handle differences between the two game versions.

Major Changes:

Merged PathfindZoneManager with refactored zone calculation logic, converting complex while loops to clearer for loops for improved readability
Updated function signatures: setTypeAsObstacle() and removeObstacle() now return Bool instead of void to indicate success
Renamed quickDoesPathExist() to clientSafeQuickDoesPathExist() across 5 call sites for consistency with Zero Hour
Added updateZonesForModify() function for incremental zone updates when structures are added/removed
Enhanced null safety with checks for m_info pointer in PathfindCell methods
Added IS_IMPASSABLE() helper function and ZONE_UPDATE_FREQUENCY constant
Changed zone recalculation tracking from boolean m_needToCalculateZones to frame-based m_nextFrameToCalculateZones
Added AI_DEBUG_ZONES enum value for debug visualization
Generals inherited Zero Hour optimizations and null-checking improvements
Zero Hour gained debugging capabilities and cleaner code formatting from Generals

Code Quality:

The conditional compilation blocks are correctly structured (contrary to previous review comments about orphaned else statements)
-Typos in comments were fixed (onlyk → only, WHen → When, succeds → succeeds)
Comment alignment improved for better readability
One minor style issue: date comment references 2025 instead of 2026

Confidence Score: 4/5

This PR is safe to merge with minimal risk - the unification is well-structured with proper conditional compilation and consistent changes across call sites
Score reflects the complexity and scope of the changes (850+ lines across core pathfinding logic) balanced against the thorough commit-by-commit approach, consistent API updates across all call sites, and sound use of preprocessor directives. The only issue found is a minor style comment about a date reference.
No files require special attention - the main AIPathfind.cpp files have the most complex changes but are well-structured

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h	unified pathfind interface with Zero Hour: updated function signatures, added null checks, renamed quickDoesPathExist to clientSafeQuickDoesPathExist, added UNINITIALIZED_ZONE enum
Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp	major unification with Zero Hour: merged PathfindZoneManager implementation, added IS_IMPASSABLE helper, updated function signatures to return Bool, added updateZonesForModify function, enhanced null safety checks; one minor date comment issue
GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h	unified with Generals: fixed typos, updated markZonesDirty signature, improved comment alignment, removed unused getNextZone declaration
GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp	unified with Generals: refactored PathfindZoneManager calculateZones to use clearer for loops and conditionals, improved code formatting and structure, added debug bounds checks for RTS_GENERALS

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Start[PathfindZoneManager::calculateZones] --> Init[Initialize zone tracking arrays]
    Init --> AllocZones[Allocate zone storage]
    AllocZones --> BlockLoop[For each zone block xBlock, yBlock]
    
    BlockLoop --> CellLoop[For each cell i, j in block]
    CellLoop --> CheckZone{Cell zone == 0?}
    CheckZone -->|Yes| AssignZone[Assign new zone m_maxZone++]
    CheckZone -->|No| CheckBridge{Cell connects bridge?}
    AssignZone --> CheckBridge
    CheckBridge -->|Yes| MarkBridge[Mark block interacts with bridge]
    CheckBridge -->|No| NextCell
    MarkBridge --> NextCell[Next cell]
    
    NextCell --> MoreCells{More cells?}
    MoreCells -->|Yes| CellLoop
    MoreCells -->|No| MoreBlocks{More blocks?}
    MoreBlocks -->|Yes| BlockLoop
    MoreBlocks -->|No| Collapse[Collapse hierarchical zones]
    
    Collapse --> MapZones[Map zones to collapsed zones]
    MapZones --> BlockCalc[Calculate zones for each block]
    BlockCalc --> CompareNeighbors[Compare neighboring cells]
    
    CompareNeighbors --> CheckLeft{i > lo.x?}
    CheckLeft -->|Yes| LeftCell{Same type as left?}
    LeftCell -->|Yes| ApplyHier1[Apply hierarchical zone]
    LeftCell -->|No| Conditional1{RTS_GENERALS?}
    Conditional1 -->|Yes| IndepChecks1[Independent terrain/water/cliff checks]
    Conditional1 -->|No| ElseLogic1[Use if-else ladder with notTerrainOrCrusher]
    
    CheckLeft -->|No| CheckTop{j > lo.y?}
    ApplyHier1 --> CheckTop
    IndepChecks1 --> CheckTop
    ElseLogic1 --> CheckTop
    
    CheckTop -->|Yes| TopCell{Same type as top?}
    TopCell -->|Yes| ApplyHier2[Apply hierarchical zone]
    TopCell -->|No| Conditional2{RTS_GENERALS?}
    Conditional2 -->|Yes| IndepChecks2[Independent terrain/water/cliff checks]
    Conditional2 -->|No| ElseLogic2[Use if-else ladder]
    
    CheckTop -->|No| NextCompare[Next cell comparison]
    ApplyHier2 --> NextCompare
    IndepChecks2 --> NextCompare
    ElseLogic2 --> NextCompare
    
    NextCompare --> MoreCompare{More cells?}
    MoreCompare -->|Yes| CompareNeighbors
    MoreCompare -->|No| Flatten[Flatten zone equivalency arrays]
    
    Flatten --> Debug{Debug mode?}
    Debug -->|Yes| DrawIcons[Draw zone visualization icons]
    Debug -->|No| SetFrame[Set m_nextFrameToCalculateZones]
    DrawIcons --> SetFrame
    SetFrame --> End[Done]

_{Last reviewed commit: 7b3588d}

greptile-apps

_{10 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

greptile-apps

_{9 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h

Mauller · 2026-02-22T17:31:44Z

Had to fix a small dependency that i missed when building debug in generals

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

Skyaero42 · 2026-02-23T08:10:26Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 {
+#if RTS_GENERALS
 	DEBUG_ASSERTCRASH(m_info, ("Has to have info."));
+#else


If m_info is not initialized, this crashes in Generals when m_info->m_pos.x is called.
Therefore the 1.01 patch can be ported to Generals. Game would have crashed at this point anyways, so it will not mismatch.

Perhaps just take Zero Hour code for both games?

Skyaero42 · 2026-02-23T11:47:54Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+			  return;
+		}
+	}
+#endif


I think this can be simplified to:

if (!ai->isDoingGroundMovement()) { #if RTS_GENERALS Bool isUnmannedHelicopter = false; #else // exception:sniped choppers are on ground Bool isUnmannedHelicopter = ( obj->isKindOf( KINDOF_PRODUCED_AT_HELIPAD ) && obj->isDisabledByType( DISABLED_UNMANNED ) ) ; #endif if ( ! isUnmannedHelicopter ) { updateAircraftGoal(obj, newGoalPos); return; } }

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Skyaero42 · 2026-02-23T20:12:52Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+	}
+#endif
+#if RTS_GENERALS
+	m_needToCalculateZones = false;


See earlier comments

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Skyaero42 · 2026-02-23T20:19:09Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+#else
+	m_zoneManager.updateZonesForModify(m_map, m_layers, cellBounds, m_extent);
+
+	Int i, j;


Move Int i, j outside of guards

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Mauller · 2026-02-23T21:56:56Z

updated based on feedback

greptile-apps

_{10 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

greptile-apps

_{10 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

greptile-apps

_{10 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h

greptile-apps · 2026-02-25T17:44:54Z

Additional Comments (1)

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h
typo: onlyk should be only

	Bool clientSafeQuickDoesPathExistForUI( const LocomotorSet& locomotorSet, const Coord3D *from, const Coord3D *to );  ///< Can we build any path at all between the locations	(terrain only - fast)

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h
Line: 659

Comment:
typo: `onlyk` should be `only`

```suggestion
	Bool clientSafeQuickDoesPathExistForUI( const LocomotorSet& locomotorSet, const Coord3D *from, const Coord3D *to );  ///< Can we build any path at all between the locations	(terrain only - fast)
```

How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{10 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

xezon · 2026-02-27T18:39:31Z

Is this meant to be Merged with Rebase? The title says "Sanitize" and "Merge" which implies 2 distinct steps and commits.

xezon

I find this review incredibly difficult. Why is the diff so big?

I do wonder if the merge needs to happen in steps, for example first add those variable r_thisCell etc, and then afterwards do the #ifdef RTS_GENERALS #else etc.

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

xezon · 2026-02-27T18:51:02Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 			cell.setZone(collapsedZones[cell.getZone()]);
-      ++i;
+			if (cell.getZone()==0) {
+				DEBUG_CRASH(("Zone not set cell %d, %d", i, j));


What is the reason for adding this assert, as opposed to removing it?

seemed like it might have been helpful

IMO it should be removed. collapsesZones[0] = 0 by definition. So if getZone() was 0, it stays 0 and the actual issue occurs earlier. This is the wrong place to test it.

xezon · 2026-02-27T18:51:08Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+
+		r_thisLayer.setZone( zone );
+		if (!r_thisLayer.isUnused() && !r_thisLayer.isDestroyed() && r_thisLayer.getZone()==0) {
+			DEBUG_CRASH(("Zone not set Layer %d", i));


What is the reason for adding this assert, as opposed to removing it?

same as above, considered it might be helpful

r_thisLayer.getZone() is never zero because if it was, the above logic (where it is set to zone = m_maxZone, with m_maxZone >= 1) this debug will never fire. It was correctly removed in ZH.

xezon · 2026-02-27T18:57:19Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 {
+#if RTS_GENERALS
 	DEBUG_ASSERTCRASH(m_info, ("Has to have info."));
+#else


Perhaps just take Zero Hour code for both games?

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

xezon · 2026-02-27T19:10:18Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+							Int zone1 = r_thisCell.getZone();
+							Int zone2 = r_leftCell.getZone();
+							if (m_terrainZones[zone1] != m_terrainZones[zone2]) {
+								//DEBUG_LOG(("Matching terrain zone %d to %d.", zone1, zone2));


This Generals code does nothing and can be removed?

this is already removed

xezon · 2026-02-27T19:11:02Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+					Int zone1 = r_thisCell.getZone();
+					Int zone2 = r_topCell.getZone();
+					if (m_terrainZones[zone1] != m_terrainZones[zone2]) {
+						//DEBUG_LOG(("Matching terrain zone %d to %d.", zone1, zone2));


This Generals code does nothing and can be removed?

this is already removed - EDIT - missed this one i was thinking of the first one, is removed now.

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Mauller · 2026-02-27T19:40:55Z

I find this review incredibly difficult. Why is the diff so big?

I do wonder if the merge needs to happen in steps, for example first add those variable r_thisCell etc, and then afterwards do the #ifdef RTS_GENERALS #else etc.

The dif is quite big because i had to change around large blocks of the zero hour and generals code within the pathfind zone manager to figure out what functionality matched. This was due to zero hour having large blocks of badly formatted refactored code, which changed parts from the generals implementation that were unecessary.

So from the zero hour code i reverted while blocks back to for blocks and cleaned up a lot of the formatting. Some of these optimisations then made their back back into generals with the r_thisCell changes since they didn't alter the functionality or mismatch.

Mauller · 2026-02-27T19:42:01Z

Is this meant to be Merged with Rebase? The title says "Sanitize" and "Merge" which implies 2 distinct steps and commits.

It can be squash merged, the title can be changed, i just considered it a bit of a sanitising as well due to the fixing of a fair bit of formatting from refactored zero hour code.

I split it into commits to make it easier to review changes

xezon · 2026-02-27T20:13:18Z

I do prefer committing small reviewable chunks to main branch. Makes it also easier to test later if something breaks. I think reviewability can be improved by doing merge in steps if some code has changed in more than one way. For example, if variables were renamed, formatting was changed, and code was added and removed, then edit these things in 3 separate commits. This will make the diffs much cleaner.

Mauller · 2026-02-27T20:17:54Z

I do prefer committing small reviewable chunks to main branch. Makes it also easier to test later if something breaks. I think reviewability can be improved by doing merge in steps if some code has changed in more than one way. For example, if variables were renamed, formatting was changed, and code was added and removed, then edit these things in 3 separate commits. This will make the diffs much cleaner.

well the biggest changes are due to pathfind zone manager, i could make a seperate PR just to cleanup the mess in that first before other unification and changes.

Skyaero42 · 2026-02-27T20:46:00Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+#endif
+
+  	//FLATTEN HIERARCHICAL ZONES
+    Int zone;


I think Int zone within the for-loop is fine (so generals style)

yes this will be tweaked with a breakout PR that's handling cleaning up a lot of the big dif due to the PathfindZoneManager changes in Zero hour compared to generals.

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

…files (#2341)

…l() (#2341)

…assifyObjectFootprint() (#2341)

…n() to examineNeighboringCells() (#2341)

…ndBrokenBridge() (#2341)

…) to changeBridgeState() (#2341)

…h() (#2341)

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

xezon

This change looks risky.

Do Generals 1.08 Replays pass without mismatching? I think some Generals replays will already fail before this change because we do not test and fix it much.

I am skeptical of the use of #if RTS_ZEROHOUR instead of #if !RTS_GENERALS.

Some #if block are difficult to read and maintain when constructed like so:

  if (...)
  {
  }
#if
  else
  {
    ...
  }
#else
  else
  {
    ...
  }
#endif

Consider a cleaner separation of #if blocks with no sneaky branch carry overs.

The commits would be better organized as logical units, as opposed to fixed regions of the code. Do we need so many individual commits? Do all commits compile in succession?

xezon · 2026-03-01T17:28:40Z

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h

+		CELL_RUBBLE		= 0x03,						///< Cell is occupied by rubble.
+		CELL_OBSTACLE	= 0x04,						///< Occupied by a structure
+		CELL_BRIDGE_IMPASSABLE = 0x05,				///< Piece of a bridge that is impassable.
+		CELL_IMPASSABLE = 0x06						///< Just plain impassable except for aircraft.


Is this value change safe?

xezon · 2026-03-01T17:30:03Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

Commit title:

Merge functions from IS_PASSABLE() to costToHierGoal()

What does this mean? I assume it means merge functions from point A to point B. But this is confusing, because 99% of readers will not know what is between these 2 code points. Generally it is better to describe like "Merge findPath related functions", "Merge debug icons related functions", ...

xezon · 2026-03-01T17:31:16Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 zoneStorageType ZoneBlock::getEffectiveZone( LocomotorSurfaceTypeMask acceptableSurfaces,
 																					 Bool crusher, zoneStorageType zone) const
 {
+	DEBUG_ASSERTCRASH(zone, ("Zone not set"));


Is this assert necessary?

xezon · 2026-03-01T17:36:13Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 			if ( i > globalBounds.lo.x && r_thisCell.getZone() != map[i-1][j].getZone() ) {
 				const PathfindCell &r_leftCell = map[i-1][j];

+				//if this is true, skip all the ones below


This looks like logic change that could mismatch

xezon · 2026-03-01T17:38:40Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 					applyZone(r_thisCell, r_topCell, m_crusherZones, m_maxZone);
 				}
+#else
+				else


Is difficult to read (and maintain) this. Perhaps this can be written better?

xezon · 2026-03-01T17:45:20Z

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+				{
 					Bool notTerrainOrCrusher = TRUE; // if this is false, skip the if-else-ladder below
-
+					


Excess tabs added.

Several times.

So are we not having both files matching when merging them 1:1 apart from the header?

xezon · 2026-03-01T17:50:33Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 		cellBounds.hi.x = bottomRightCorner.x;
 		cellBounds.hi.y = bottomRightCorner.y;

+#if RTS_GENERALS


Are all of the new RTS_GENERALS still necessary without RETAIL_COMPATIBLE_CRC (or RETAIL_COMPATIBLE_PATHFINDING) ? Will we never drop the Generals specific code in Pathfind?

No the generals specific code will always be here while we are maintaining retail compatibility for generals.

The altered code in most places mismatches pretty quickly when the zero hour version are used in generals.

xezon · 2026-03-01T17:53:28Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

 			}
 		}
 	}
+#if RTS_ZEROHOUR


Better use !RTS_GENERALS instead, because RTS_ZEROHOUR is inconsistent with

#ifdef RTS_GENERALS ... #else ... // Strictly, code in here means !RTS_GENERALS, not RTS_ZEROHOUR #endif

Many times in this change.

xezon · 2026-03-01T17:57:00Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

+	if (obj->getHeightAboveTerrain() > PATHFIND_CELL_SIZE_F && ( ! obj->isKindOf( KINDOF_BLAST_CRATER ) ) ) {
+		return; // Don't add bounds that are up in the air.... unless a blast crater wants to do just that
+#endif
 	}


Better make this part of the #ifdef blocks

xezon · 2026-03-01T18:49:56Z

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

-			examinedZones[numExZones] = newZone;
-			numExZones++;
-		}
+		if( adjNewCell->hasInfo() ) {


Is this a logic change?

Mauller self-assigned this Feb 22, 2026

Mauller added Critical Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Unify Unifies code between Generals and Zero Hour labels Feb 22, 2026

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 60286bd to e20892a Compare February 22, 2026 17:09

greptile-apps bot reviewed Feb 22, 2026

View reviewed changes

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Outdated Show resolved Hide resolved

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from e20892a to 180cc40 Compare February 22, 2026 17:15

greptile-apps bot reviewed Feb 22, 2026

View reviewed changes

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h Outdated Show resolved Hide resolved

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h Outdated Show resolved Hide resolved

bobtista reviewed Feb 22, 2026

View reviewed changes

Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h Outdated Show resolved Hide resolved

bobtista reviewed Feb 22, 2026

View reviewed changes

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h Show resolved Hide resolved

bobtista reviewed Feb 22, 2026

View reviewed changes

GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h Outdated Show resolved Hide resolved

Skyaero42 changed the title ~~unify(pathfinder): Sanatize and merge AIPathfind and dependencies~~ unify(pathfinder): Sanitize and merge AIPathfind and dependencies Feb 23, 2026

Skyaero42 requested changes Feb 23, 2026

View reviewed changes

greptile-apps bot reviewed Feb 23, 2026

View reviewed changes

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Show resolved Hide resolved

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 75d3750 to 35a0d0a Compare February 23, 2026 22:09

greptile-apps bot reviewed Feb 23, 2026

View reviewed changes

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Show resolved Hide resolved

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 35a0d0a to dc18e3d Compare February 25, 2026 17:40

greptile-apps bot reviewed Feb 25, 2026

View reviewed changes

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from dc18e3d to 87f4e50 Compare February 25, 2026 21:18

greptile-apps bot reviewed Feb 25, 2026

View reviewed changes

xezon reviewed Feb 27, 2026

View reviewed changes

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 83c85c8 to da9b94b Compare February 27, 2026 19:53

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from da9b94b to 6ca4994 Compare February 27, 2026 19:58

Skyaero42 reviewed Feb 27, 2026

View reviewed changes

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 6ca4994 to 55be278 Compare March 1, 2026 16:19

greptile-apps bot reviewed Mar 1, 2026

View reviewed changes

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Outdated Show resolved Hide resolved

GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Outdated Show resolved Hide resolved

Mauller added 8 commits March 1, 2026 16:31

unify(pathfinder): Merge standalone data and functions in the header …

b4207e3

…files (#2341)

unify(pathfinder) Merge functions from IS_PASSABLE() to costToHierGoa…

83ab3f9

…l() (#2341)

unify(pathfinder): Merge PathfindZoneManager functions (#2341)

809372c

unify(pathfinder): Merge functions from doDebugIcons() to internal_cl…

7371715

…assifyObjectFootprint() (#2341)

unify(pathfinder): Merge functions from chooseBestLocomotorForPositio…

b245a23

…n() to examineNeighboringCells() (#2341)

unify(pathfinder): Merge functions from buildHierarchicalPath() to fi…

baaa138

…ndBrokenBridge() (#2341)

unify(pathfinder): Merge functions from clientSafeQuickDoesPathExist(…

383b355

…) to changeBridgeState() (#2341)

unify(pathfinder): Merge functions from updateGoal() to Findattackpat…

7b3588d

…h() (#2341)

Mauller force-pushed the Mauller/unify-aipathfind-easyparts branch from 55be278 to 7b3588d Compare March 1, 2026 16:42

greptile-apps bot reviewed Mar 1, 2026

View reviewed changes

Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp Show resolved Hide resolved

xezon removed the Critical Severity: Minor < Major < Critical < Blocker label Mar 1, 2026

Mauller changed the title ~~unify(pathfinder): Sanitize and merge AIPathfind and dependencies~~ unify(pathfinder): Merge AIPathfind and update dependencies Mar 1, 2026

xezon reviewed Mar 1, 2026

View reviewed changes

		{
		Bool notTerrainOrCrusher = TRUE; // if this is false, skip the if-else-ladder below

Conversation

Mauller commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mauller commented Feb 22, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mauller commented Feb 23, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Feb 25, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xezon commented Feb 27, 2026

Uh oh!

xezon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Mauller commented Feb 22, 2026 •

edited

Loading

greptile-apps bot commented Feb 22, 2026 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

xezon left a comment •

edited

Loading

Mauller Feb 27, 2026 •

edited

Loading

Mauller commented Feb 27, 2026 •

edited

Loading

Mauller commented Feb 27, 2026 •

edited

Loading