Better handling of cancelled/failed redirect logins (PP-3961)#137
Open
tdilauro wants to merge 3 commits into
Open
Better handling of cancelled/failed redirect logins (PP-3961)#137tdilauro wants to merge 3 commits into
tdilauro wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds cancel-detection and error-recovery to the SAML, OIDC, and Clever auth redirect handlers, preventing infinite redirect loops when a login attempt is cancelled or fails.
When a patron initiates an external auth login, the handler redirects to an identity provider via a hard browser navigation. Previously, returning to the app without completing auth — via browser back, closing a popup, or an IdP-side failure — caused the handler to immediately redirect again, trapping the patron in a loop.
Key changes:
Special cases:
bfcachesupport: Safari restores pages from its back-forward cache without re-running React effects. A special event listener detects this case so that the cancelled message can be displayed correctly.Motivation and Context
Users attempting to log in via redirect-based authentication -- SAML, OIDC, or Clever -- who cancelled mid-flow or failed to authenticate could become trapped in an infinite redirect loop without an obvious way out.
[Jira PP-3961]
How Has This Been Tested?
Checklist: