Add opt-in "Play on startup" setting#75
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/TheJoeFin/Trdo/sessions/bbe887a0-8caa-4095-9da8-05b4aa6e901b Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix auto-start issue for version 1.80
Add opt-in "Play on startup" setting
Apr 1, 2026
Show a warning InfoBar when enabling "Auto-play on startup" to inform users that audio will start automatically. Require explicit confirmation via an "Enable anyway" button. Refactor toggle logic to use event handler and OneWay binding. Rename "Enable Auto-Resume" to "Auto-recover" with updated description. Use shared PlayerViewModel instance in SettingsViewModel.
Adjusted clamping logic to use maxX and maxY with System.Math.Max, preventing negative clamp ranges when window size exceeds work area. This ensures window positions remain within valid screen bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app restores the previously selected station on launch but never begins playback automatically. Users expecting audio to start immediately after the app opens (especially when launched at Windows startup) had no way to enable this behavior.
Changes
SettingsService— newAutoPlayOnStartupbool persisted inLocalSettings, defaults tofalseto prevent unexpected autoplayPlayerViewModelconstructor — calls_player.Play()immediately after stream initialization whenAutoPlayOnStartupis setSettingsViewModel— exposesIsAutoPlayOnStartupEnabledandAutoPlayOnStartupToggleTextfor two-way UI bindingSettingsPage.xaml— adds a "Play on startup"ToggleSwitchbelow the existing "Open on startup" toggle with a descriptive subtitleSetting is opt-in to avoid the confusing/annoying experience of music starting unexpectedly on every login.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ndavsblobprodwus219.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/7308510B18BD5F018EBF4978576AFCBB/missingpackages_workingdir --packages /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)If you need me to access, download, or install something from one of these locations, you can either: