Feature/task bench support by guptapratykshh · Pull Request #6876 · TheHPXProject/hpx

guptapratykshh · 2026-02-04T07:20:54Z

Fixes #4274

Proposed Changes

Added a new example examples/task_bench/ that builds the HPX task-bench drivers from the upstream task-bench repository (StanfordLegion/task-bench) via CMake FetchContent. No task-bench source files are vendored in this PR — everything is fetched from upstream.
Two binaries are built:
- hpx_fork_join — fork-join executor for intra-node parallelism (no MPI required)
- hpx_distributed — default parallel executor + MPI for inter-node parallelism (built only when MPI is found)
Added a new option HPX_WITH_EXAMPLES_TASKBENCH (default OFF) that gates the example. Users must explicitly enable it (-DHPX_WITH_EXAMPLES_TASKBENCH=ON) to build task-bench alongside HPX.
The example is automatically skipped on Windows (POSIX-only dependency in task-bench's core/ library) and when HPX_WITH_DISTRIBUTED_RUNTIME=OFF.

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

I have added a new feature and have added tests to go along with it.
I have fixed a bug and have added a regression test.
I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

StellarBot · 2026-02-04T07:25:03Z

Can one of the admins verify this patch?

hkaiser

@guptapratykshh Did you implement the HPX version of task_bench?

guptapratykshh · 2026-02-04T14:32:44Z

Yes, i am working on HPX implementation, utilizing hpx::execution::experimental::fork_join_executor to efficiently handle intra node parallelism for task graph

hkaiser · 2026-02-05T14:38:23Z

Yes, i am working on HPX implementation, utilizing hpx::execution::experimental::fork_join_executor to efficiently handle intra node parallelism for task graph

Thanks! The only thing I'm unsure of is whether we really should add the whole task_bench code base to our repository. Wouldn't it be better to upstream your changes to them?

guptapratykshh · 2026-02-06T05:57:41Z

@hkaiser, you are right, i have upstreamed the implementation to task bench - StanfordLegion/task-bench#101
once that is merged, i will update this pr to remove duplicated task bench code from HPX and add minimal example that uses task bench as an external dependency

hkaiser · 2026-03-28T14:37:30Z

@guptapratykshh I'm going to close this without merging. Please re-open if you feel that we will pursue this PR any further.

guptapratykshh · 2026-04-14T03:26:06Z

@hkaiser now we should re-open this PR as this StanfordLegion/task-bench#101 is merged as well as the race condition(StanfordLegion/task-bench#94 (comment)) has also been fixed in that PR

hkaiser · 2026-04-14T11:41:56Z

@guptapratykshh when pushing to this PR, please remove the task-bench code by force-pushing to remove it completely from the git history.

codacy-production · 2026-04-14T11:43:05Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Copilot

Pull request overview

Adds TaskBench benchmark support to the HPX examples by integrating an external TaskBench checkout and building HPX TaskBench driver executables as part of the examples build.

Changes:

Introduces examples/task_bench CMake logic that fetches TaskBench and builds the core library + HPX driver executables.
Adds task_bench to the top-level examples subdirectory list so it is built when examples are enabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
examples/task_bench/CMakeLists.txt	Fetches upstream TaskBench and defines build targets for TaskBench core + HPX drivers.
examples/CMakeLists.txt	Registers `task_bench` as an examples subdirectory.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

hkaiser · 2026-05-06T19:39:28Z

While this looks good in principle, I'd like to avoid pulling in the new example unconditionally. Could you please add an explicit option HPX_WITH_EXAMPLES_TASKBENCH (which defaults to OFF) guarding its inclusion?

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

+# (https://github.com/StanfordLegion/task-bench) as an external dependency. No
+# task-bench source files are vendored here.
+
+cmake_minimum_required(VERSION 3.17)


+# core_random.c and siphash.c are C files; enable C so cmake can compile them.
+enable_language(C)
+


+find_package(MPI)
+if(MPI_FOUND)
+  if(COMMAND add_hpx_executable)


+hpx_option(
+  HPX_WITH_EXAMPLES_TASKBENCH
+  BOOL
+  "Enable the task-bench example (fetched from upstream StanfordLegion/task-bench, default: OFF)."
+  OFF
+  CATEGORY "Build Targets"
+  ADVANCED


Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

examples/task_bench/CMakeLists.txt:94

Same issue as above: target_link_libraries(hpx_distributed PRIVATE hpx_include) refers to a non-existent target and will break the build. Rely on add_hpx_executable’s default HPX linkage or link against an actual exported HPX target (e.g. HPX::hpx).

    add_hpx_executable(
      hpx_distributed
      SOURCES "${task_bench_SOURCE_DIR}/hpx/hpx_distributed.cc"
      FOLDER "Examples/TaskBench"
    )
    target_link_libraries(hpx_distributed PRIVATE hpx_include)
  else()

+  # hpx_include carries the libs/full/include/include path (and all its
+  # transitive module deps such as hpx_segmented_algorithms) that hpx/hpx.hpp
+  # requires. It is only defined when HPX_WITH_DISTRIBUTED_RUNTIME=ON, which is
+  # already guaranteed by the guard above.
+  target_link_libraries(hpx_fork_join PRIVATE hpx_include)
+else()


+# on Windows. Skip the entire example on MSVC builds.
+if(MSVC)


+if(HPX_WITH_EXAMPLES_TASKBENCH)
+  set(subdirs ${subdirs} task_bench)
+endif()


Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

guptapratykshh force-pushed the feature/task_bench_support branch 9 times, most recently from 8b98668 to 76253cb Compare February 4, 2026 11:04

hkaiser reviewed Feb 4, 2026

View reviewed changes

hkaiser added the category: examples label Feb 4, 2026

hkaiser added this to the 2.0.0 milestone Mar 28, 2026

hkaiser closed this Mar 28, 2026

hkaiser reopened this Apr 14, 2026

guptapratykshh force-pushed the feature/task_bench_support branch from e014ade to 464f5de Compare April 14, 2026 16:45

guptapratykshh changed the title ~~[Draft] [WIP] Feature/task bench support~~ Feature/task bench support Apr 14, 2026

guptapratykshh marked this pull request as ready for review April 14, 2026 16:50

Copilot AI review requested due to automatic review settings April 14, 2026 16:50

Copilot started reviewing on behalf of guptapratykshh April 14, 2026 16:51 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 14, 2026 17:37

guptapratykshh force-pushed the feature/task_bench_support branch from 20c5f35 to 302334a Compare April 14, 2026 17:37

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread examples/task_bench/CMakeLists.txt Outdated

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Copilot AI review requested due to automatic review settings April 15, 2026 04:31

guptapratykshh force-pushed the feature/task_bench_support branch from 211e50d to f4b86a5 Compare April 15, 2026 04:31

Copilot started reviewing on behalf of guptapratykshh April 15, 2026 04:31 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Copilot AI review requested due to automatic review settings April 15, 2026 05:09

Copilot started reviewing on behalf of guptapratykshh April 15, 2026 05:10 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

Comment thread examples/task_bench/CMakeLists.txt

guptapratykshh force-pushed the feature/task_bench_support branch from aed6eb3 to 4b57333 Compare April 16, 2026 13:43

Copilot AI review requested due to automatic review settings May 7, 2026 02:03

Copilot started reviewing on behalf of guptapratykshh May 7, 2026 02:04 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

guptapratykshh added 11 commits May 13, 2026 10:24

add task_bench example using upstream StanfordLegion/task-bench

86fbf7c

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

fix cmake-format and enable C language for task_bench_core

e1e39cf

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

fix hpx/hpx.hpp not link hpx_include explicitly

3022d53

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

fix hpx/hpx.hpp not found by adding direct include path

c980712

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

suppress C++ MPI bindings to fix undefined ompi symbols

17d437a

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

use hpx_include target + dist-runtime guard

24414a3

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

register targets with example pseudo-target system

18eac12

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

skip on MSVC

7001b65

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

gate task_bench example behind HPX_WITH_EXAMPLES_TASKBENCH option

9b774b5

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

fix cmake-format

a93ed84

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

bump cmake_minimum_required to 3.18 to match HPX top-level

ea25a41

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

Copilot AI review requested due to automatic review settings May 13, 2026 04:54

guptapratykshh force-pushed the feature/task_bench_support branch from 9efda81 to ea25a41 Compare May 13, 2026 04:54

Copilot started reviewing on behalf of guptapratykshh May 13, 2026 04:55 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

skip task_bench on all Windows toolchains, not just MSVC

25151fa

Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>

guptapratykshh requested a review from hkaiser May 14, 2026 05:05

		# core_random.c and siphash.c are C files; enable C so cmake can compile them.
		enable_language(C)

		# on Windows. Skip the entire example on MSVC builds.
		if(MSVC)

Uh oh!

Conversation

guptapratykshh commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Any background context you want to provide?

Checklist

Uh oh!

StellarBot commented Feb 4, 2026

Uh oh!

hkaiser left a comment

Choose a reason for hiding this comment

Uh oh!

guptapratykshh commented Feb 4, 2026

Uh oh!

hkaiser commented Feb 5, 2026

Uh oh!

guptapratykshh commented Feb 6, 2026

Uh oh!

hkaiser commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guptapratykshh commented Apr 14, 2026

Uh oh!

hkaiser commented Apr 14, 2026

Uh oh!

codacy-production Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hkaiser commented May 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

guptapratykshh commented Feb 4, 2026 •

edited

Loading

hkaiser commented Mar 28, 2026 •

edited

Loading

codacy-production Bot commented Apr 14, 2026 •

edited

Loading