ci: fix migration-policy false positives from shallow base fetch - #8
Merged
Merged
Conversation
The policy.yml checkout already fetches full history, but this script then re-fetched the base ref with --depth=1. A shallow base ref grafts away its ancestry, so origin/BASE..HEAD stopped excluding the base tip's ancestors; on a PR branch that merged the base in (Update branch) historical base commits reappeared in the range and tripped the commit-metadata rule. Fetch the base full-depth and scope the scan to merge-base(BASE,HEAD)..HEAD. No change to what the policy forbids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates the fix already merged in librtbit-upnp-serve (#4). The script re-fetched the base ref
--depth=1despite the workflow checking out full history; the shallow graft madeorigin/BASE..HEADreappear historical base commits after an Update-branch merge, tripping the commit-metadata rule on commits the PR never touched. Fix: fetch base full-depth + scope tomerge-base(BASE,HEAD)..HEAD. No change to what the policy forbids.