Repository navigation
ENH: DWI quality-control criteria - #464
Merged
Merged
Conversation
Collaborator
|
Roadmap triage: this WIP from 2024 ("feel free to add quality criteria for DWI") is incomplete and has gone stale. Recommend closing or converting the remaining intent into a tracking issue, so the DWI QC criteria can be picked up fresh when there's bandwidth. |
Fills in the WIP DWI quality-control criteria, adapting the visual-assessment guidance for the MRIQC diffusion reportlets (Hagen et al., Nat. Protoc. 2026, doi:10.1038/s41596-026-01352-y): - qaqc-criteria-unprocessed.md: write the previously-empty "shell-wise joint distribution of SNR vs FA" criteria (FA-SNR correlation, non-normal per-shell SNR, shell overlap); complete the FA-map criteria (resolves the [WHAT ELSE?] placeholder) and expand the MD-map, voxel-wise average/SD, and background criteria. Fix the heading level of the standard-deviation subsection and a couple of typos. Cite the protocol ([2]). - mriqc.md: wire the diffusion procedure to the criteria — fix the broken empty anchor and add the FA/MD/average-SD/background cross-links. `mkdocs build` is warning-free and all five DWI anchors resolve. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
oesteban
force-pushed
the
enh/qc_criteria_dwi
branch
from
June 12, 2026 14:30
2dc94a1 to
ffe6f66
Compare
oesteban
marked this pull request as ready for review
June 12, 2026 14:31
oesteban
changed the title
Collaborator
Completed — DWI QC criteria written from the MRIQC protocolPicking this up from the WIP stub (the blocker was simply that the criteria were never written — "@oesteban feel free to add quality criteria for DWI"). Rebased onto
@celprov / @oesteban — since you both co-authored the source protocol, a quick check that the adapted thresholds match how you want them applied in the HCPh SOP would be ideal before merging. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The FOV fold-over (wrap-around) is most legible on the flickering average/standard-deviation reportlet, so consolidate the criterion there and drop the redundant copies from the FA- and MD-map sections. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…he FA map Orientation errors stem from the NIfTI orientation header and are quickest to spot on the FA map, so make that the canonical check -- naming the qform/sform fields explicitly -- and drop the generic duplicates from the MD map and the average view. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Tighten every entry to short, imperative checks (dropping the protocol's pedagogical explanations, which neuroimagers don't need): e.g. the wrap-around check becomes "Search for wrap-around artifacts (typically along the phase-encoding direction)". Replace the prose pointer to the fMRI background view with an actual cross-link. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
oesteban
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oesteban feel free to add quality criteria for DWI