Skip to content

Repin the nine PolicyEngine-US implementations to their marked commit - #1908

Merged
MaxGhenis merged 1 commit into
mainfrom
register-pe-us-markers
Oct 24, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
register-pe-us-markers

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

PolicyEngine/policyengine-us#10441 (merge commit eeaf8096) put a # Source conflict <id> marker in each of the nine PolicyEngine-US files this register lists as an implementation. This repins those nine implementations to eeaf8096 and sets cites_entry: true, so verify checks that each file still names its entry. It changes only known-source-conflicts.yaml, and in it only each of those nine implementations' commit and cites_entry.

Entry File (under policyengine_us/) Old pin
us-co:oap-interest-and-dividends parameters/gov/states/co/ssa/oap/income/sources/unearned.yaml 7bb70aab
us-md:poverty-credit-earned-income-losses variables/gov/states/md/tax/income/credits/poverty_line/md_poverty_line_credit_potential.py 79249f0f
us:niit-magi-trust-code-h-adjustment variables/gov/irs/tax/federal_income/niit_magi.py 7bb70aab
us:qbid-net-capital-gain-investment-election variables/gov/irs/income/taxable_income/deductions/qualified_business_income_deduction/section_199a_net_capital_gain.py 7bb70aab
us:dependent-care-exclusion-separate-filer-income variables/gov/irs/credits/cdcc/min_head_spouse_earned.py 7bb70aab
us-hi:care-credit-claimable-unclaimed-filer variables/gov/states/hi/tax/income/credits/cdcc/hi_cdcc_eligible.py 7bb70aab
us-ny:dependent-standard-deduction-filing-status variables/gov/states/ny/tax/income/taxable_income/deductions/ny_standard_deduction.py 7bb70aab
us-wv:senior-disability-modification-income-base variables/gov/states/wv/tax/income/subtractions/senior_citizen_disability/wv_senior_citizen_disability_deduction_person.py 7bb70aab
us-mn:msa-guardian-fee-cap variables/gov/states/mn/dhs/msa/payment/mn_msa_guardian_fee.py 7bb70aab

What the new pin holds

  • The commit: eeaf8096 is on PolicyEngine-US's default branch. It was main's head when this was written.
  • The markers: cites_global_id, the same function verify uses, finds each entry's global id in its file at eeaf8096, and in none of them at the old pin.
  • What else changed: comparing each file at its old pin with eeaf8096, eight differ only by the marker line.
  • The tests keep their own pins:
    • each still names a case that exists at its commit;
    • pinned-tests reuses its cached passes for unchanged (repository, commit, ids) keys;
    • nothing here moves a test.

Verification

  • A parsed comparison with main's register confirms that the only changes are the nine implementations' commit and cites_entry.
  • python3 tools/source_conflicts.py check: 22 entries, 0 issues, 0 unregistered open interpretations.
  • CI's verify checks the new pins: each file exists and names its global id, and each commit is on its default branch.

Next

A PolicyEngine-US pin bump vendors this register, together with rulespec-us#1907's entries. PolicyEngine-US's guard then enforces these nine markers through cites_entry: true.

🤖 Generated with Claude Code

PolicyEngine/policyengine-us#10441 (merge eeaf8096) put a
`# Source conflict <id>` marker in each of the nine PolicyEngine-US files
this register lists as an implementation. Pin those implementations to
eeaf8096 and set cites_entry: true, so verify checks that each file still
names its entry. The pinned tests keep their own commits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis marked this pull request as ready for review October 24, 2026 16:07
@MaxGhenis
MaxGhenis merged commit ad03b32 into main Oct 24, 2026
64 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Merged by the Axiom engineering hub at 3b30430 with --merge. Gates: gh pr checks exit 0; MERGEABLE; not draft. Reviewed head: 3b30430. Owner handed over the ready head. An independent GPT-6.1 Sol review approved it with no findings: the diff changes exactly 18 parsed values, the commit pin and cites_entry flag of the nine PolicyEngine-US implementations, all repinned to the merge of PolicyEngine/policyengine-us#10441. The repository's own marker predicate holds at the new pin and fails at the old pins; eight files differ only by the marker line; Minnesota still applies the same reading; pin_runner cache keys are unchanged. Register metadata only; no RuleSpec content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant