typing: bound recursive quick sort to Comparable protocol - #15473
Closed
Silverbullets1 wants to merge 3 commits into
Closed
Silverbullets1 wants to merge 3 commits into
Silverbullets1 wants to merge 3 commits into
Conversation
- Any-era hints -> Comparable Protocol + TypeVar bound, __lt__-only partitioning - recursive_quick_sort added to tests/test_sorts.py battery + reject test - doctests: strings, floats+ints mix, mixed [1, 'a'] raises TypeError Part of TheAlgorithms#15234
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Checklist
Part of #15234 (the
recursive_quick_sort.pycheckbox).This PR types the recursive quick sort for any comparable items:
Anyelement type with theComparableProtocol+TypeVarbound (quick_sort[T: Comparable](data: list[T]) -> list[T]), matching the pattern already checked in for other sorts in this issue (e.g.bogo_sort).__lt__:not data[0] < efor the left partition anddata[0] < efor the right, replacing the former mix of<=and>.quick_sort([1, "a"])raisesTypeError.recursive_quick_sortjoins the shared battery intests/test_sorts.py: it is added to bothtest_sort_matches_builtin(all existing cases) andtest_sort_rejects_non_comparable_items, plus a dedicatedtest_recursive_quick_sort_mixed_types.Verification:
Best,
Sam | Lead Engineer
DevilX Digital Labs
https://devilx-solution.vercel.app/