Core/Creature: Add support for multiple gossip menu IDs - #472
Merged
Ovahlord merged 4 commits intoJul 25, 2026
Merged
Conversation
Adds support for assigning multiple gossip menu IDs to creatures and controlling them through conditions. Cherry-picked and adapted from: TrinityCore/TrinityCore@36044a9 Also disables StormLib automatic static linking. StormLib fix suggested by @brian8544 on Discord.
gonzo1247
force-pushed
the
creatureGossip
branch
from
July 25, 2026 15:25
76a1b9b to
ecb263f
Compare
Ovahlord
merged commit Jul 25, 2026
9da95e6
into
The-Cataclysm-Preservation-Project:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for assigning multiple gossip menu IDs to creatures and controlling them through conditions.
Some creatures in Cataclysm use different gossip menu IDs for the same creature entry. With this implementation, adapted from TrinityCore master, this can now be handled through the database without requiring a custom C++ script.
Cherry-picked and adapted from:
TrinityCore/TrinityCore@36044a9
This PR also disables StormLib's automatic static linking.
The StormLib fix was suggested by @brian8544 on Discord.
This PR supersedes and updates #433:
#433
Tests performed: (Does it build, tested in-game, etc)
Build,
Worked Ingame