Core/Pets: Correct SMSG_PET_SLOT_UPDATED - #471
Merged
Ovahlord merged 1 commit intoJul 6, 2026
Merged
Conversation
Ovahlord
merged commit Jul 6, 2026
3d13b2a
into
The-Cataclysm-Preservation-Project:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large pet GUIDs can cause a client crash when moving a pet from the stable to the call list or vice versa.
After researching and reverse-engineering the handling of the incoming SMSG_PET_SLOT_UPDATED packet in the client, I determined that the field order was incorrect.
With the previous field order, the client interpreted the pet GUID as the slot index, which could result in an out-of-bounds access when the GUID was too large.
Tests performed: (Does it build, tested in-game, etc)