Skip to content

fix: stop realtime feed before freeing data frames on disconnect (heap corruption, #98) #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blurxy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop realtime feed before freeing data frames on disconnect (heap corruption, #98) #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/project_x_py/trading_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,17 +982,22 @@ async def disconnect(self) -> None:
"""
logger.info("Disconnecting TradingSuite...")

# Disconnect realtime FIRST so the SignalR background reader thread is
# quiesced before any Polars data frames it writes into are freed. The
# previous order (cleanup contexts -> disconnect realtime) freed the
# frames while the reader was still live, racing native SignalR threads
# against Polars memory and corrupting the heap on disconnect
# (Windows STATUS_HEAP_CORRUPTION / 0xc0000374). See issue #98.
if self.realtime:
await self.realtime.disconnect()

if self._instruments:
# Multi-instrument mode - disconnect all contexts
await self._disconnect_instrument_contexts()
else:
# Legacy single-instrument mode
await self._disconnect_legacy_single_instrument()

# Disconnect realtime
if self.realtime:
await self.realtime.disconnect()

# Clean up client context
if hasattr(self, "_client_context") and self._client_context:
try:
Expand Down