Skip to content

perps(klear): reject non-canonical dates in margin-report range validation (#409) #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TexasCoding merged 1 commit into from
Jun 5, 2026
Merged

perps(klear): reject non-canonical dates in margin-report range validation (#409) #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions kalshi/perps/klear/resources/margin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,19 @@ def _validate_date_range(start_date: str, end_date: str) -> None:
f"start_date / end_date must be YYYY-MM-DD strings (got "
f"start_date={start_date!r}, end_date={end_date!r}): {exc}"
) from exc
# ``date.fromisoformat`` (3.11+) also accepts non-canonical forms like
# "20260605" or ISO week dates ("2026-W23-5"), which the raw string would
# then forward to a server expecting strict YYYY-MM-DD. Require the canonical
# form so the SDK rejects them here rather than relying on a server 400.
for label, raw, parsed in (
("start_date", start_date, start),
("end_date", end_date, end),
):
if parsed.isoformat() != raw:
raise ValueError(
f"{label} must be a canonical YYYY-MM-DD date, got {raw!r} "
f"(parsed as {parsed.isoformat()})"
)
if end < start:
raise ValueError(
f"end_date ({end_date}) must be on or after start_date ({start_date})"
Expand Down
6 changes: 6 additions & 0 deletions tests/perps/klear/test_margin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ def test_rejects_malformed_or_inverted_dates_client_side(
auth_klear_client.margin.margin_reports(start_date="nope", end_date="2026-06-01")
with pytest.raises(ValueError, match="on or after"):
auth_klear_client.margin.margin_reports(start_date="2026-06-02", end_date="2026-06-01")
# #409: fromisoformat is lenient — reject non-canonical forms that would
# otherwise be forwarded raw to a server expecting strict YYYY-MM-DD.
with pytest.raises(ValueError, match="canonical YYYY-MM-DD"):
auth_klear_client.margin.margin_reports(start_date="20260501", end_date="2026-06-01")
with pytest.raises(ValueError, match="canonical YYYY-MM-DD"):
auth_klear_client.margin.margin_reports(start_date="2026-05-01", end_date="2026-W22-1")
assert not route.called
auth_klear_client.close()

Expand Down