First homework - #1
Open
Testbek wants to merge 2 commits into
Open
Conversation
dirtymew
approved these changes
Jan 25, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Привет Вячеслав
хорошая работа - тесты проходят
зачет
| // ваш код здесь | ||
| ... | ||
| // ваш код здесь | ||
| return ((18 * meanSpeed(action, duration) * runningCaloriesMeanSpeedShift) * weight / mInKm * duration * minInH) |
There was a problem hiding this comment.
нужно константу было использовать runningCaloriesMeanSpeedMultiplier
Owner
Author
There was a problem hiding this comment.
Спасибо, в следующий раз буду повнимательней.
| // ваш код здесь | ||
| ... | ||
| // ваш код здесь | ||
| return (walkingCaloriesWeightMultiplier*weight + (math.Pow(meanSpeed(action, duration)*kmhInMsec, 2)/(height/cmInM))*walkingSpeedHeightMultiplier*weight) * duration * minInH |
There was a problem hiding this comment.
тут возможно деление на 0 если height == 0
Owner
Author
There was a problem hiding this comment.
тут возможно деление на 0 если height == 0
Как правильно было бы сделать проверку на 0, не используя дополнительные строчки кода, если это возможно?
There was a problem hiding this comment.
а кто запретил код писать?
в данном случае можно вот так просто
if height == 0 {
return 0
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have 2.20 want 2.27