fix(test): enforce diff dry-run exit code#289
Open
zengxm1979 wants to merge 1 commit into
Open
Conversation
Walkthrough
ChangesDry-run verdict gate
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ This PR is linked to an issue assigned to @zengxm1979 — thanks! The |
zengxm1979
marked this pull request as ready for review
July 26, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
test diff --dry-runpath so it preserves the documented CI-gate behavior when the emitted sample shows a verdict change.Root cause
The real
test diffpath prints the diff and throwsCLIError(..., 1)whenverdictChangedis true. The dry-run path prints a canned sample withverdictChanged: true, but returned successfully before reaching the same exit-1 gate.Change
CLIErrorwhensample.verdictChangedis true.exitCode: 1.Workflow note
Issue #286 has been claimed with
/assignper the contribution workflow.Validation
npm test -- src/commands/test.test.ts -t "runDiff"npm run typechecknpm run lintnpm run format:checkAll checks passed locally on Node v24.15.0 / npm 11.12.1.
Closes #286