fix(homebridge-teslemetry): finish npm publish readiness for the same-name major hard cut - #70
Conversation
…-name major hard cut - Add publishConfig (access/provenance) and a package-local LICENSE file, matching the other publishable packages - the legacy 0.4.x package ships a LICENSE and the monorepo package had none. - Fix the README's license/contributing links, which pointed at a root LICENSE/CONTRIBUTING.md that doesn't exist anywhere in this repo. - Remove the config.schema.json/settings.ts latitude/longitude "Homelink" fields - Homelink was dropped in the #63 hard cut but the dead config survived, so real users would see a config option with no effect. - Rewrite the stale "Phase 1/Phase 2 coming soon" feature list to match what's actually implemented in src/vehicle-services and src/energy-services.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb68c92d1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Each energy site appears as its own set of accessories: | ||
|
|
||
| - **Battery** - Charge level | ||
| - **Operation Mode** - Switch between self-consumption, backup, autonomous, and time-based control |
There was a problem hiding this comment.
For users selecting the documented time-based operation mode, the service does not switch modes: operation-mode.ts explicitly treats time_based_control as read-only, logs a warning, and returns without calling the API (lines 93–100). Document this mode as status-only rather than listing it among the modes users can switch to.
Useful? React with 👍 / 👎.
1 participant
Intent
homebridge-teslemetry, version baseline1.0.0), but the package still had a few loose ends before a real npm publish would be clean.publishConfig(access/provenance) matching every other publishable package (api,n8n-nodes-teslemetry,node-red-contrib-teslemetry,iobroker.teslemetry) -homebridge-teslemetrywas the only one missing it.LICENSEfile (the legacy 0.4.x tarball ships one; this package didn't) and included it infiles. Fixed the README'sLICENSE/CONTRIBUTING.mdlinks, which pointed at root-level files that don't exist anywhere in this repo.latitude/longitude"Homelink Location" fields fromconfig.schema.jsonandsettings.ts- Homelink itself was dropped in the feat(homebridge-teslemetry): same-name major hard cut over legacy package #63 service-count reduction (11 vehicle services, no Homelink) but this dead config survived, so real users installing today would see a config option that does nothing.changeset publishcorrectly detectshomebridge-teslemetry@1.0.0as unpublished and attempts it via OIDC trusted publishing, but npm returnsE404 Not Found - PUT .../homebridge-teslemetry. Someone with npm org-owner access onhomebridge-teslemetryneeds to register this repo's GitHub Actions workflow as a trusted publisher on npmjs.com (Package Settings → Trusted Publisher) before the next merge tomainwill succeed. No repo changes can work around this - it's an npmjs.com-side registration.homebridge-teslemetryis already at1.0.0inpackage.jsonand unpublished on npm, sochangeset publishwill publish it as-is on the next successful CI run - adding a changeset now would just bump past1.0.0before it ever ships. Confirmed locally:npm packproduces a 6-file tarball (dist/,config.schema.json,LICENSE,package.json,README.md) matching the legacy package's essential file set.1.0.0is live, runnpm deprecate homebridge-teslemetry@"<0.5.0" "Superseded by homebridge-teslemetry@1.0.0 (monorepo rewrite) - see https://github.com/Teslemetry/typescript-teslemetry/tree/main/packages/homebridge-teslemetry"against the legacy 0.4.x line.teslemetry/homebridgeGitHub repo per the captain's no-dual-maintain ruling.Verified locally:
pnpm --filter homebridge-teslemetry build/tsc/test(90/90 passing),pnpm lint,pnpm -r --no-bail tsc+iobroker.teslemetry check, fullpnpm test, andpnpm --filter homebridge-teslemetry packall pass.