Skip to content

fix(icon): restore Ask AI icons in the Covalent icon font - #2785

Merged
omaardev merged 1 commit into
mainfrom
feat-DSYS-1015
Sep 9, 2026
Merged

omaardev merged 1 commit into
mainfrom
feat-DSYS-1015

Conversation

@Luis-HCC-2000

Copy link
Copy Markdown
Collaborator

Description

Fixes product_ask_ai and product_ask_ai_outlined not rendering in the Covalent icon font. The icons were already included in the icon list, but their generated font ligature mappings were missing.

These changes follow the documented icon update process in README.md.

What's included?

  • Added the missing ligatures for product_ask_ai and product_ask_ai_outlined
  • Regenerated the SVG, TTF, and WOFF font assets
  • Updated the CSS and SCSS font cache key
  • Updated the packaged icon font from v2.12 to v2.13
  • Verified both icons render in the Storybook Covalent icon gallery

Test Steps

  • Run npm run storybook
  • Navigate to Components > Icon > All Covalent Icons
  • Verify product_ask_ai renders correctly
  • Verify product_ask_ai_outlined renders correctly
  • Confirm both icons render using their corresponding CSS classes

Validation

  • npx nx run icons:build --skip-nx-cache
  • Verified both ligatures in a fresh Storybook session
  • Confirmed generated font files match the v2.13 archive
  • Confirmed CSS, SCSS, and variable mappings are complete

General Tests for Every PR

  • npm run start still works
  • npm run lint passes
  • npm run stylelint passes
  • npm test passes and code coverage is not lower
  • npm run build still works
Screenshots or link to StackBlitz/Plunker

Before this PR:
image

After this PR:
image

Copilot AI lite review requested due to automatic review settings September 9, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Restores missing ligature mappings so product_ask_ai and product_ask_ai_outlined render correctly in the Covalent icon font, along with asset/cache updates.

Changes:

  • Added missing glyph/ligature entries for product_ask_ai and product_ask_ai_outlined in the SVG font source
  • Updated CSS/SCSS font asset cache-buster keys to align with regenerated font outputs
  • Regenerated icon font assets (implied by updated mappings and cache keys)

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

File Description
libs/icons/covalent-icons.svg Adds the missing glyph ligatures for the Ask AI icons so they can render via font ligatures.
libs/icons/covalent-icons.scss Updates the font URL cache key to ensure clients pick up the regenerated font assets.
libs/icons/covalent-icons.css Updates the font URL cache key to ensure clients pick up the regenerated font assets.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Copilot reviewed 2 out of 6 changed files in this pull request and generated no new comments.

@omaardev
omaardev merged commit 28ad750 into main Sep 9, 2026
9 checks passed
@omaardev
omaardev deleted the feat-DSYS-1015 branch September 9, 2026 21:19
@omaardev

omaardev commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 11.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants