Skip to content

Fix uninitvar miss on ternary (?:) condition #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
watte1997 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

Fix uninitvar miss on ternary (?:) condition #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions samples/cpp/uninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,15 @@ void Demo(int b)
}
// 缺少else分支，变量a可能不会初始化
a++;
}

unsigned short TernaryDemo(unsigned short input)
{
unsigned char flag;
if (input > 0)
{
flag = 1;
}
// 三目运算符的条件会读取变量flag
return flag ? 10 : 0;
}
4 changes: 4 additions & 0 deletions trunk/lib/checkuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,10 @@ int CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, Alloc all
return (var && var->typeStartToken()->isStandardType());
}

const Token *parent = vartok->astParent();
if (alloc == NO_ALLOC && Token::simpleMatch(parent, "?") && parent->astOperand1() == vartok)
return true;

if (alloc == NO_ALLOC && vartok->next() && vartok->next()->isOp() && !vartok->next()->isAssignmentOp())
return true;

Expand Down